Added esConsumes to SiPixelRecHitConverter #29914

Dr15Jones · 2020-05-19T19:27:14Z

PR description:

In addition, consolidated header and source file as well as some code modernization and naming consistency.

PR validation:

The code compiles.

cmsbuild · 2020-05-19T19:27:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-19T19:32:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29914/15514

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelRecHits/interface/SiPixelRecHitConverter.h modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitConverter.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-05-19T19:33:26Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @gpetruc, @ebrondol, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-05-19T19:33:33Z

please test

cmsbuild · 2020-05-19T19:33:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6440/console Started: 2020/05/19 21:36

cmsbuild · 2020-05-19T22:12:50Z

-1

Tested at: 799b8f9

CMSSW: CMSSW_11_1_X_2020-05-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

First version of DeepMET #29764 @steggema: First version of DeepMET
Apply code checks to the CondFormats packages #29879 @fwyzard: Apply code checks to the CondFormats packages
Apply code checks to the OnlineDB packages #29891 @fwyzard: Apply code checks to the OnlineDB packages
Apply code checks to the Alignment packages #29875 @fwyzard: Apply code checks to the Alignment packages
[Payload Inspector] Add more SiPixel inspection classes #29864 @mmusich: [Payload Inspector] Add more SiPixel inspection classes
Apply code checks to the CalibMuon packages #29876 @fwyzard: Apply code checks to the CalibMuon packages
Remove obsolete HardEventHypothesis class #29903 @perrotta: Remove obsolete HardEventHypothesis class
add track filter for N tracks with minimum pt #29604 @antoniovagnerini: add track filter for N tracks with minimum pt
Skip CUDA-related tests if no GPU is present #29902 @cms-patatrack: Skip CUDA-related tests if no GPU is present
DQM: Clean up DQMServices/Core and its usages #29742 @schneiml: DQM: Clean up DQMServices/Core and its usages
MillePede: force user to specify cosmics-related settings #29838 @adewit: MillePede: force user to specify cosmics-related settings
Clean up of CondDB interface #29828 @ggovi: Clean up of CondDB interface
Add SiPixelVCal DB object for pixel gain calibration #29829 @IzaakWN: Add SiPixelVCal DB object for pixel gain calibration

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6440/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6440/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6440/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test TestDQMOnlineClient-sistrip_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.793 step3

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step3_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.874 step3

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

11634.0 step2

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

12434.0 step2

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:05:10 2020-date Wed May 20 00:02:35 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:27 2020-date Wed May 20 00:02:39 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:08:15 2020-date Wed May 20 00:02:42 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_MC.root --fileout file:RelVal_Raw_2018_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:15 2020-date Wed May 20 00:02:42 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:05:50 2020-date Wed May 20 00:02:43 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:05:50 2020-date Wed May 20 00:02:43 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:08:13 2020-date Wed May 20 00:02:48 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:13 2020-date Wed May 20 00:02:48 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:07:11 2020-date Wed May 20 00:02:52 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_DATA.root --fileout file:RelVal_Raw_2018_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:07:11 2020-date Wed May 20 00:02:52 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:07:47 2020-date Wed May 20 00:02:53 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:07:47 2020-date Wed May 20 00:02:53 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:12 2020-date Wed May 20 00:03:00 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:30 2020-date Wed May 20 00:03:03 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:08:04 2020-date Wed May 20 00:03:04 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:04 2020-date Wed May 20 00:03:04 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:49 2020-date Wed May 20 00:03:06 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:06:58 2020-date Wed May 20 00:03:10 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:06:58 2020-date Wed May 20 00:03:10 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:07:33 2020-date Wed May 20 00:03:23 2020 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed May 20 00:08:45 2020-date Wed May 20 00:05:15 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:45 2020-date Wed May 20 00:05:15 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Wed May 20 00:08:36 2020-date Wed May 20 00:05:59 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Wed May 20 00:11:17 2020-date Wed May 20 00:07:04 2020 s - exit: 18688

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

First version of DeepMET #29764 @steggema: First version of DeepMET
Apply code checks to the CondFormats packages #29879 @fwyzard: Apply code checks to the CondFormats packages
Apply code checks to the OnlineDB packages #29891 @fwyzard: Apply code checks to the OnlineDB packages
Apply code checks to the Alignment packages #29875 @fwyzard: Apply code checks to the Alignment packages
[Payload Inspector] Add more SiPixel inspection classes #29864 @mmusich: [Payload Inspector] Add more SiPixel inspection classes
Apply code checks to the CalibMuon packages #29876 @fwyzard: Apply code checks to the CalibMuon packages
Remove obsolete HardEventHypothesis class #29903 @perrotta: Remove obsolete HardEventHypothesis class
add track filter for N tracks with minimum pt #29604 @antoniovagnerini: add track filter for N tracks with minimum pt
Skip CUDA-related tests if no GPU is present #29902 @cms-patatrack: Skip CUDA-related tests if no GPU is present
DQM: Clean up DQMServices/Core and its usages #29742 @schneiml: DQM: Clean up DQMServices/Core and its usages
MillePede: force user to specify cosmics-related settings #29838 @adewit: MillePede: force user to specify cosmics-related settings
Clean up of CondDB interface #29828 @ggovi: Clean up of CondDB interface
Add SiPixelVCal DB object for pixel gain calibration #29829 @IzaakWN: Add SiPixelVCal DB object for pixel gain calibration

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6440/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6440/git-merge-result

cmsbuild · 2020-05-19T22:12:53Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

In addition, consolidated header and source file as well as some code modernization and naming consistency.

cmsbuild · 2020-05-20T00:25:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-20T00:30:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29914/15520

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelRecHits/interface/SiPixelRecHitConverter.h modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitConverter.cc modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-05-20T00:30:43Z

Pull request #29914 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

Dr15Jones · 2020-05-20T00:31:28Z

please test

cmsbuild · 2020-05-20T00:31:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6447/console Started: 2020/05/20 02:32

cmsbuild · 2020-05-20T03:33:13Z

+1
Tested at: afb139e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6447/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

First version of DeepMET #29764 @steggema: First version of DeepMET
Apply code checks to the CondFormats packages #29879 @fwyzard: Apply code checks to the CondFormats packages
Apply code checks to the OnlineDB packages #29891 @fwyzard: Apply code checks to the OnlineDB packages
Apply code checks to the Alignment packages #29875 @fwyzard: Apply code checks to the Alignment packages
[Payload Inspector] Add more SiPixel inspection classes #29864 @mmusich: [Payload Inspector] Add more SiPixel inspection classes
Apply code checks to the CalibMuon packages #29876 @fwyzard: Apply code checks to the CalibMuon packages
Remove obsolete HardEventHypothesis class #29903 @perrotta: Remove obsolete HardEventHypothesis class
add track filter for N tracks with minimum pt #29604 @antoniovagnerini: add track filter for N tracks with minimum pt
Skip CUDA-related tests if no GPU is present #29902 @cms-patatrack: Skip CUDA-related tests if no GPU is present
DQM: Clean up DQMServices/Core and its usages #29742 @schneiml: DQM: Clean up DQMServices/Core and its usages
MillePede: force user to specify cosmics-related settings #29838 @adewit: MillePede: force user to specify cosmics-related settings
Clean up of CondDB interface #29828 @ggovi: Clean up of CondDB interface
Add SiPixelVCal DB object for pixel gain calibration #29829 @IzaakWN: Add SiPixelVCal DB object for pixel gain calibration

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6447/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6447/git-merge-result

cmsbuild · 2020-05-20T03:33:16Z

Comparison job queued.

cmsbuild · 2020-05-20T06:53:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d660/6447/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 50 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2694466
DQMHistoTests: Total failures: 66
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2694351
DQMHistoTests: Total skipped: 49
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 150 log files, 16 edm output root files, 35 DQM output files

slava77 · 2020-05-21T02:10:42Z

+1

for #29914 afb139e

code changes are technical, in line with the PR description
jenkins tests pass and comparisons with the baseline show no (relevant) differences
- differences in comparisons are from First version of DeepMET #29764 also included in the tests

cmsbuild · 2020-05-21T02:11:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-21T08:00:33Z

+1

cmsbuild added this to the CMSSW_11_1_X milestone May 19, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 19, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 19, 2020

cmsbuild added tests-started and removed tests-pending labels May 19, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 19, 2020

Added esConsumes to SiPixelRecHitConverter

afb139e

In addition, consolidated header and source file as well as some code modernization and naming consistency.

Dr15Jones force-pushed the esConsumesSiPixelRecHitConverter branch from 799b8f9 to afb139e Compare May 20, 2020 00:24

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-notrun tests-rejected labels May 20, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 20, 2020

cmsbuild added tests-started and removed tests-pending labels May 20, 2020

cmsbuild added tests-approved and removed tests-started labels May 20, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 20, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels May 21, 2020

cmsbuild added orp-approved and removed orp-pending labels May 21, 2020

cmsbuild merged commit 6be1085 into cms-sw:master May 21, 2020

Dr15Jones deleted the esConsumesSiPixelRecHitConverter branch June 8, 2020 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added esConsumes to SiPixelRecHitConverter #29914

Added esConsumes to SiPixelRecHitConverter #29914

Dr15Jones commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

Dr15Jones commented May 19, 2020

cmsbuild commented May 19, 2020 •

edited

Loading

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

Dr15Jones commented May 20, 2020

cmsbuild commented May 20, 2020 •

edited

Loading

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

slava77 commented May 21, 2020

cmsbuild commented May 21, 2020

silviodonato commented May 21, 2020

Added esConsumes to SiPixelRecHitConverter #29914

Added esConsumes to SiPixelRecHitConverter #29914

Conversation

Dr15Jones commented May 19, 2020

PR description:

PR validation:

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

Dr15Jones commented May 19, 2020

cmsbuild commented May 19, 2020 • edited Loading

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

Dr15Jones commented May 20, 2020

cmsbuild commented May 20, 2020 • edited Loading

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

cmsbuild commented May 20, 2020

slava77 commented May 21, 2020

cmsbuild commented May 21, 2020

silviodonato commented May 21, 2020

cmsbuild commented May 19, 2020 •

edited

Loading

cmsbuild commented May 20, 2020 •

edited

Loading