-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run2 re-miniAOD setup based on UL inputs #29756
run2 re-miniAOD setup based on UL inputs #29756
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29756/15191
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: Configuration/ProcessModifiers @perrotta, @pgunnell, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @slava77, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
+1 |
It is just a confirmation from conveners (@roger-wolf, @rmanzoni) that Tau POG likes it. |
+xpog yes, for NanoAOD there will be a follow up in a separate pull request, that will come once the updates for MiniAOD are integrated |
+operations |
merge |
ah. So, the tests were not redone while the PUPPI PR was merged. This broke the tests in the IB |
The relevant lines to change for these workflow are likely these: |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
@slava77 sorry I just saw your comment about PheDEX. I think it should be fine even the input is not at CERN. We can switch these lines to search at other sites. |
run2_miniAOD_UL
process modifier is introduced for UL reminiAOD needs.(ctpps_2016 & run2_miniAOD_UL).toModify
run2_miniAOD_UL16extra
, but hopefully this can be avoidedTTbar_13_reminiaod2017UL_INPUT
I couldn't find an AODSIM relval with PU and use a RECO input insteadA summary of limited validation for 1325.517 (MC 2017) by comparing the original 10_6_X MINIAOD with remini in CMSSW_11_1_X_2020-05-04-1100 using FWLite: the differences are apparently in recognizable places where changes were introduced since 10_6_X
@chayanit @pgunnell @wajidalikhan please let me know if you can make PhedEx request for the datasets proposed here in the tests or if an alternative can be transferred (I can make an update to the PR then)