Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL trigger] V11 geometry compatibility #29400

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

jbsauvan
Copy link
Contributor

@jbsauvan jbsauvan commented Apr 7, 2020

PR description:

Add compatibility with the V11 geometry.
Depends on external cms-data/L1Trigger-L1THGCal#17

PR validation:

Tested V9, V10 and V11 worflows

runTheMatrix.py -w upgrade -l 20034.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 20434.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 22034.0 --maxSteps=2

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29400/14547

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Apr 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

The tests are being triggered in jenkins.

@rekovic
Copy link
Contributor

rekovic commented Apr 7, 2020

abort test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

Jenkins tests are aborted.

@rekovic
Copy link
Contributor

rekovic commented Apr 7, 2020

needs to be tested with external cms-data/L1Trigger-L1THGCal#17 (attn @mrodozov )

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 7, 2020

test parameters
pull requests = cms-data/L1Trigger-L1THGCal#17

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

The tests are being triggered in jenkins.

@mrodozov
Copy link
Contributor

mrodozov commented Apr 7, 2020

its like

test parameters:
- pull requests = cms-data/L1Trigger-L1THGCal#17

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-L1THGCal#17
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5648/console Started: 2020/04/10 11:36

@cmsbuild
Copy link
Contributor

+1
Tested at: 30ab4cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52c2b8/5648/summary.html
CMSSW: CMSSW_11_1_X_2020-04-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52c2b8/5648/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694590
  • DQMHistoTests: Total failures: 76
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694195
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@rekovic
Copy link
Contributor

rekovic commented Apr 14, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants