HCAL: HBHE MC 8TS->10TS move for >=Run3

[abdoulline]

PR description:

Intended for better description of high SiPMs noise (which is spread in time between TS' - Time Slices of 25ns) at the end of Run3 and in Run4 by simulating extended Digi frame (10TS) and using last 8TS of it in local Reco, (omitting the first 2TS' with some noise deficit). Preparatory PR #28948 (for Reco repacking of Digi input) merged earlier.
ZS (Zero Suppression) range modified accordingly.

Two (cmsDriver) customization snippets, one per each modified CMSSW package, are provided for possible reverting of both modifications:
(1) Digi frame size back to 8TS
(2) ZS algo & range - back to legacy 2TS option
(+ reverting conditions: tag HcalZSThresholds)
for fully reproducing 11_0_0 Hcal Digis in 11_1_0, if needed :

--customise
SimCalorimetry/HcalSimProducers/HBHE_revert_8TS_cff.customise_8TS,
SimCalorimetry/HcalZeroSuppressionProducers/HBHE_ZSrevert_2TS_cff.customise_2TS

Some small changes (Digi random generator sequence altered, impacting also MAHI reconstruction results) expected for >= Run3.
Here is a single-pion 0PU calorimetry scan results (wrt regular 11_1_0_pre3) for Run3 2021:
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/Run3/11_1_0_pre3_run3_newZS_FlexSOI_10TSSOI5_vs_11_1_0_pre3_run3_SinglePi/

PR validation:

runTheMatrix.py -l limited

if this PR is a backport

No backport needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29035/13901

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalZeroSuppressionProducers

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4888/console Started: 2020/02/26 11:59

[cmsbuild]

+1
Tested at: 58e9725
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70e644/4888/summary.html
CMSSW: CMSSW_11_1_X_2020-02-25-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70e644/4888/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70e644/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70e644/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70e644/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70e644/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70e644/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70e644/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2679706
• DQMHistoTests: Total failures: 219896
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2459491
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1