-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFlow fix/improvement in the HF region for phase2 #28442
PFlow fix/improvement in the HF region for phase2 #28442
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28442/12853
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28442/12854 |
A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master. It involves the following packages: CommonTools/BaseParticlePropagator @perrotta, @ssekmen, @lveldere, @sbein, @civanch, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 2af5fe5 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
the crash looks related
|
I added a few more plots to the post above. |
+1
|
+1 |
I added the answer above, but yes, your understanding is correct. |
thanks |
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@hatakeyamak in order to prepare the backport requested by @fwyzard could you please provide already the PR there, so as we can launch the tests? |
it looks like the same topic branch will work |
I had impression that I don't have to do anything as @slava77 indicated, but please let me know if anything is necessary for backport. |
you still need to submit a pull request (even though you do not need to create a new branch) |
+1 |
PR description:
This PR introduces the first attempt of track-HF cluster matching in PFAlgo for phase 2. It shouldn't impact Run2 and Run3 reconstruction, but improves phase2 reconstruction. Before this PR, tracks and HF clusters in |eta|=3-4 region have been heavily double-counting charged particles in this region, which will be largely remedied in this PR. This PR introduces kdtree-based linking between tracks and HF clusters, and links are utilized in mostly createCandidatesHF of PFAlgo.
Also, the propagator is fixed to make the track propagation to HF to work for particles with pt<3 GeV also (which was broken in the past, as it didn't matter).
Also, the HF face is updated to be in agreement with the actual geometry.
PR validation:
http://hep.baylor.edu/hatake/PFval/PFForwardTrack/stack_offset_SinglePiPt50Eta3p45_3p54_2026D41_PU200_v0_vs_v5.pdf
shows the improved offset quantities. [Horns around |eta|=3-4 much reduced with this update.]
I made sure, using PF validation code, that 2018 QCD plots show no differences.
if this PR is a backport please specify the original PR:
This is not a backport.
@bendavid @jpata @iashvili @mariadalfonso