Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for dqm #26745

Merged
merged 2 commits into from
May 15, 2019
Merged

Running code-format for dqm #26745

merged 2 commits into from
May 15, 2019

Conversation

cmsbuild
Copy link
Contributor

Applying code-format for CMSSW category dqm.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/206//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26745/9736

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/149/console Started: 2019/05/10 17:16

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/EcalMonitorTasks
DQM/HcalTasks
DQM/SiPixelPhase1Track
DQM/SiStripCommissioningClients
DQM/SiStripMonitorHardware
Validation/MuonHits
Validation/RecoVertex

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@erikbutz, @DryRun, @hdelanno, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @argiro, @fioriNTU, @deguio, @jandrea, @mtosi, @idebruyn, @ebrondol, @VinInn, @threus, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b4be4/149/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-1b4be4/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 133
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211627
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b13393b into master May 15, 2019
@DryRun
Copy link
Contributor

DryRun commented May 26, 2019

Hi, will this be backported to 10_6_X? I would like to make a backport of #26941, but it can't be merged into 10_6_X because of these changes.

@fabiocos
Copy link
Contributor

@DryRun in general no, we are not going to massively backport whatever code-format change. I think that dedicated cases will have to be managed ad hoc.

@DryRun
Copy link
Contributor

DryRun commented May 26, 2019

@fabiocos OK, thanks. Could I ask how I should proceed in this case? I.e. how to pull the code-format changes for a single file?

@fabiocos
Copy link
Contributor

@DryRun not sure about what you are exactly trying to do, in any case you may just checkout from the master only the modified file you are interested in and update that one.

@smuzaffar smuzaffar deleted the code-format-dqm-29f030 branch May 31, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants