-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running code-format for dqm #26745
Running code-format for dqm #26745
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26745/9736
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DQM/EcalMonitorTasks @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hi, will this be backported to 10_6_X? I would like to make a backport of #26941, but it can't be merged into 10_6_X because of these changes. |
@DryRun in general no, we are not going to massively backport whatever code-format change. I think that dedicated cases will have to be managed ad hoc. |
@fabiocos OK, thanks. Could I ask how I should proceed in this case? I.e. how to pull the code-format changes for a single file? |
@DryRun not sure about what you are exactly trying to do, in any case you may just checkout from the master only the modified file you are interested in and update that one. |
Applying code-format for CMSSW category dqm.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/206//console
cms-bot has successfully run the following: