RecoLocalTracker/SiPixelRecHits: change return type of ESProducer's to unique_ptr. #22031
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22031/3130 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: RecoLocalTracker/SiPixelRecHits @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
| // cpe_ = std::make_shared<PixelCPETemplateReco>(pset_,magfield.product(),lorentzAngle.product(),templateDBobject.product() ); | ||
| cpe_ = std::make_shared<PixelCPETemplateReco>(pset_,magfield.product(),*pDD.product(),*hTT.product(),lorentzAngleProduct,templateDBobject.product() ); | ||
| return cpe_; | ||
| // cpe_ = std::make_unique<PixelCPETemplateReco>(pset_,magfield.product(),lorentzAngle.product(),templateDBobject.product() ); |
There was a problem hiding this comment.
please remove the commented code or update it to match the latest update // return std::make_unique ...
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22031/3146 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
1) Reimplementing change from shared_ptr to unique_ptr from cms-sw#22031, and also applying the same principle to PixelCPEClusterRepairESProducer. 2) going with label = "numerator" in SiPixel2DTemplateDBObjectESProducer.cc. This corresponds to data, in particular to Barrel Layer 1 from the end of 2017 run. This is what we want to test in data. Given what we have in the DB right now, this is the most useful at the moment. 3) cosmetic: fix typo in python variable name in SiPixel2DTemplateDBObjectESProducer_cfi.py (2D2D -> 2D)
|
For the record: this was lost, then found, then reimplemented in #22458. Sorry about that. |
1) Reimplementing change from shared_ptr to unique_ptr from cms-sw#22031, and also applying the same principle to PixelCPEClusterRepairESProducer. 2) going with label = "numerator" in SiPixel2DTemplateDBObjectESProducer.cc. This corresponds to data, in particular to Barrel Layer 1 from the end of 2017 run. This is what we want to test in data. Given what we have in the DB right now, this is the most useful at the moment. 3) cosmetic: fix typo in python variable name in SiPixel2DTemplateDBObjectESProducer_cfi.py (2D2D -> 2D)
No description provided.