Thread safe piliup histogram for mixing

[civanch]

Addressing issue #21972 , implemented as suggested by @Dr15Jones .

[cmsbuild]

The code-checks are being triggered in jenkins.

[civanch]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22000/3088

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25699/console Started: 2018/01/27 21:51

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

Mixing/Base

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

To avoid future problems, it would be nice to

• change PileUp's constructor to take a std::shared_ptr<const PileUpConfig>
• change PileUpConfig to hold a std::shared_ptr<const TH1F>

That will keep anyone from begin able to call a non-const function of the TH1F without first copying the histogram.

[cmsbuild]

+1
Tested at: e9e0626
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22000/25699/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22000/25699/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22000/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2464350
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2464180
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.13999999998 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[fabiocos]

@civanch thank you for adjusting the PR, as it was already signed I take it.

[fabiocos]

merge

[fabiocos]

@Dr15Jones @civanch I have merged this PR as urgent fix, but I ask the simulation group to look at the further suggestions by Chris and propose an integration

[davidlange6]

one could imagine changing the constructor to take either the const array of PDF values from the PSet or the CDF that is actually used. There is really no need to have used a TH1* in the PileUp class (other than the desire to dump out a root file containing that histogram with each job we run in production...) as the usage is actually not of the histogram but of its CDF.

…

On Jan 27, 2018, at 9:42 PM, Chris Jones ***@***.***> wrote: To avoid future problems, it would be nice to • change PileUp's constructor to take a std::shared_ptr<const PileUpConfig> • change PileUpConfig to hold a std::shared_ptr<const TH1F> That will keep anyone from begin able to call a non-const function of the TH1F without first copying the histogram. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.