Preliminary HGCAL trigger clustering #18419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… upgrade on the clustering algorithm + rename of some file
…dev/hgc-tpg-devel-CMSSW_9_0_0_pre4 (include SimClustering)
…the clustering algorithms + modification to the dataformat to include a collection of clusters in the multicluster + some minor modification to the parameters python and HGCClusterAlgo.cc class
Clustering infrastructure
…clustering and multiclutering next commit will use references
…e collection references instead of unique_ptr to collections + add of parameter for geometrical cluster 2D in hgcalTriggerPrimitiveDigiProducer_cfi.py
…) member functions as const in HGCalCluster class
…in IC code just to debug the C2d (need the sum of the energy)
+ modifications to the cluster classes and their implementation: parsing of the eventSetup and Event in the clusterise functions (needed to retrieve GlobalPointers to the cartesian position of the 2D) + creation of a *temporary-C3d* used to test the C2d + global cleaning
…turns the calibrated pT in mip units
…vector<HGCalTriggerCell*> and std::vector<Cluster*> have been implemented + removal of Event and EventSetup from the clustering functions parameters, using the GlobalPointer from TC
…clustering and multiclutering next commit will use references
…e collection references instead of unique_ptr to collections + add of parameter for geometrical cluster 2D in hgcalTriggerPrimitiveDigiProducer_cfi.py
…) member functions as const in HGCalCluster class
…in IC code just to debug the C2d (need the sum of the energy)
davidlange6
reviewed
Apr 27, 2017
| @@ -371,15 +422,38 @@ void HGCalTriggerGeomTester::checkConsistency(const HGCalTriggerGeometryBase::es | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| std::cout<<"Checking trigger cell neighbor consistency\n"; | |||
There was a problem hiding this comment.
Hi @jbsauvan - please use the message logger here (and just below)
|
Thanks @davidlange6 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following:
This depends on external cms-data/L1Trigger-L1THGCal#4, but tests can be run without these data.