Clean up the pixel local reconstruction code #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address the pixel local reconstruction review comments: - remove obsolete comments; - consistently use named constants; - rename data members and methods to be more descriptive; - update transient dictionaries to match data types.
fwyzard
force-pushed
the
address_pixel_local_reco_review_comments_part4
branch
from
02db05c
to
5d6c35e
Compare
Address the pixel local reconstruction review comments: - remove obsolete comments.
Address the pixel local reconstruction review comments:
- rename local variables according to the coding rules and for
consistency with cms-sw#32591.
fwyzard
added a commit
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
Validation summaryReference release CMSSW_11_2_0 at ed67564 Validation plots/RelValTTbar_14TeV/CMSSW_11_2_0_pre11-PU_112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
Validation plots (CPU vs GPU)/RelValTTbar_14TeV/CMSSW_11_2_0_pre11-PU_112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
Address the pixel local reconstruction review comments:
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591.
fwyzard
force-pushed
the
address_pixel_local_reco_review_comments_part4
branch
from
9a42341
to
e503ab5
Compare
fwyzard
added a commit
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Dec 30, 2020
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Jan 13, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Jan 15, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Mar 23, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
fwyzard
added a commit
that referenced
this pull request
Apr 1, 2021
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the pixel local reconstruction review comments: