Clean up the pixel local reconstruction code #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
force-pushed
the
address_pixel_local_reco_review_comments_part2
branch
from
5b90263
to
e5f1d1a
Compare
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments - update data members for better consistency - remove unimplemented method
fwyzard
force-pushed
the
address_pixel_local_reco_review_comments_part2
branch
from
e5f1d1a
to
ba19e88
Compare
fwyzard
added a commit
that referenced
this pull request
Dec 25, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
fwyzard
added a commit
that referenced
this pull request
Dec 25, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
fwyzard
added a commit
that referenced
this pull request
Dec 25, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the pixel local reconstruction review comments.
General clean up of the pixel local reconstruction code: