move to int32 for hit indices #583

VinInn · 2020-11-25T10:23:57Z

No description provided.

fwyzard · 2020-11-26T14:03:06Z

Validation summary

Reference release CMSSW_11_2_0_pre10 at 6c149b2
Development branch cms-patatrack/master at 47423b3
Testing branch cms-patatrack/master at 47423b3 with PRs:

move to int32 for hit indices #583 at 7877d3a

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.5
⚠️ tracking validation plots and summary for workflow 11634.501 are missing
tracking validation plots and summary for workflow 11634.502
⚠️ tracking validation plots and summary for workflow 11634.505 are missing
tracking validation plots and summary for workflow 11634.506

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.5
tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502
tracking validation plots and summary for workflow 11634.505
tracking validation plots and summary for workflow 11634.506

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.5
tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.502
tracking validation plots and summary for workflow 11634.505
tracking validation plots and summary for workflow 11634.506

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

⚠️ tracking validation plots and summary for workflows 11634.502 and 11634.501 are missing
⚠️ tracking validation plots and summary for workflows 11634.506 and 11634.505 are missing

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501
tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501
tracking validation plots and summary for workflows 11634.506 and 11634.505

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and `nvprof`/`nvvp` profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

reference release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.501
- ❌ step3.py: log
development release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.505
- ❌ step3.py: log
development release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.511
- ✔️ step3.py: log
development release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
development release, workflow 11634.521
- ✔️ step3.py: log
development release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 136.885502
development release, workflow 136.885512
development release, workflow 136.885522
testing release, workflow 11634.5
- ✔️ step3.py: log
testing release, workflow 11634.501
- ❌ step3.py: log
testing release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.505
- ❌ step3.py: log
testing release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.511
- ✔️ step3.py: log
testing release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
testing release, workflow 11634.521
- ✔️ step3.py: log
testing release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 136.885502
testing release, workflow 136.885512
testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

reference release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.501
- ✔️ step3.py: log
development release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.505
- ✔️ step3.py: log
development release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.511
- ✔️ step3.py: log
development release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
development release, workflow 11634.521
- ✔️ step3.py: log
development release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 136.885502
development release, workflow 136.885512
development release, workflow 136.885522
testing release, workflow 11634.5
- ✔️ step3.py: log
testing release, workflow 11634.501
- ✔️ step3.py: log
testing release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.505
- ✔️ step3.py: log
testing release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.511
- ✔️ step3.py: log
testing release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
testing release, workflow 11634.521
- ✔️ step3.py: log
testing release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 136.885502
testing release, workflow 136.885512
testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

reference release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.5
- ✔️ step3.py: log
development release, workflow 11634.501
- ✔️ step3.py: log
development release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.505
- ✔️ step3.py: log
development release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 11634.511
- ✔️ step3.py: log
development release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
development release, workflow 11634.521
- ✔️ step3.py: log
development release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
development release, workflow 136.885502
development release, workflow 136.885512
development release, workflow 136.885522
testing release, workflow 11634.5
- ✔️ step3.py: log
testing release, workflow 11634.501
- ✔️ step3.py: log
testing release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.505
- ✔️ step3.py: log
testing release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 11634.511
- ✔️ step3.py: log
testing release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
testing release, workflow 11634.521
- ✔️ step3.py: log
testing release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
- ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
testing release, workflow 136.885502
testing release, workflow 136.885512
testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/13a7a77294b8e32b503b6abf63fcf96c22939c56/log .

fwyzard · 2020-11-27T10:53:46Z

The impact on the throughput for quadruplets is around 1-2%.

No effect on the physics results, as expected.

fwyzard · 2020-11-27T11:01:05Z

I understand the change in data type.
What does hitToTuple do ?

VinInn · 2020-11-27T11:24:28Z

kernel_checkOverflows is not run in standard wf
hitToTuple is just a oneToMany association between hits and ntuple; it tells in which tuple a hit is. It is used mainly (only?) by the infamous shred-hit--cleaner (see #552)

in kernel_checkOverflows is just used to count (and eventually identify) the doublets that do not share any hit with an already built tracks (as requested by you in case lepton reconstruction would require them)

It is experimental code.
This is why I suggested to start from #545 for the hit size issue

RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h

fwyzard · 2020-11-27T23:16:45Z

Throughput re-checked by hand:

Running 3 times over 4100 events with 1 jobs, each with 8 threads, 8 streams and 1 GPUs

master

quadruplets: 1136.7 ± 6.4 ev/s
triplets: 671.7 ± 2.9 ev/s

master + #583

quadruplets: 1132.5 ± 4.5 ev/s
triplets: 667.6 ± 1.6 ev/s

In both cases the drop is less than 1%.

Add a counter for forlorn doublets.

VinInn added 2 commits November 25, 2020 01:41

increase maxhit, count forlon doublets

23c546e

fix hit index in phi binner

7877d3a

VinInn mentioned this pull request Nov 25, 2020

use uint32 to index hits [do not merge] #474

Closed

fwyzard changed the base branch from master to CMSSW_11_2_X_Patatrack November 25, 2020 10:38

fwyzard added the Pixels Pixels-related developments label Nov 26, 2020

fwyzard reviewed Nov 27, 2020

View reviewed changes

RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h Outdated Show resolved Hide resolved

fwyzard added 3 commits November 27, 2020 20:54

Remove commented out code

1af9050

Apply code formatting

62a0c30

Apply code formatting

2c8573d

fwyzard merged commit 83081a8 into CMSSW_11_2_X_Patatrack Nov 27, 2020

fwyzard pushed a commit that referenced this pull request Nov 27, 2020

Move hit indexes to 32 bits (#583)

5d7beeb

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Nov 27, 2020

Move hit indexes to 32 bits (#583)

8a391aa

Add a counter for forlorn doublets.

fwyzard mentioned this pull request Dec 1, 2020

Modifications to run GPU HIon menu on PbPb 2018 data #545

Closed

This was referenced Dec 14, 2020

Patatrack integration - Pixel local reconstruction (9/N) cms-sw/cmssw#31721

Merged

Open issues regarding the Pixel local reconstruction on GPU cms-sw/cmssw#32483

Open

fwyzard pushed a commit that referenced this pull request Dec 25, 2020

Move hit indexes to 32 bits (#583)

a9ee972

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Dec 26, 2020

Move hit indexes to 32 bits (#583)

978db84

Add a counter for forlorn doublets.

fwyzard mentioned this pull request Dec 26, 2020

Patatrack integration - Pixel vertex reconstruction (11/N) cms-sw/cmssw#31723

Merged

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Move hit indexes to 32 bits (#583)

7650971

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Move hit indexes to 32 bits (#583)

3cfeee9

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Move hit indexes to 32 bits (#583)

3aa5c94

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Move hit indexes to 32 bits (#583)

b643d1b

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Jan 13, 2021

Move hit indexes to 32 bits (#583)

1b1105e

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Jan 15, 2021

Move hit indexes to 32 bits (#583)

c62b37b

Add a counter for forlorn doublets.

fwyzard mentioned this pull request Jan 15, 2021

Patatrack integration - Pixel track reconstruction (10/N) cms-sw/cmssw#31722

Merged

fwyzard pushed a commit that referenced this pull request Mar 23, 2021

Move hit indexes to 32 bits (#583)

fa74c72

Add a counter for forlorn doublets.

fwyzard pushed a commit that referenced this pull request Apr 1, 2021

Move hit indexes to 32 bits (#583)

7473687

Add a counter for forlorn doublets.

fwyzard mentioned this pull request Jun 23, 2021

[cudadev] Update the CUDA implementation to the version in CMSSW 12.0.0-pre3 cms-patatrack/pixeltrack-standalone#191

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move to int32 for hit indices #583

move to int32 for hit indices #583

VinInn commented Nov 25, 2020

fwyzard commented Nov 26, 2020 •

edited

Loading

fwyzard commented Nov 27, 2020

fwyzard commented Nov 27, 2020

VinInn commented Nov 27, 2020

fwyzard commented Nov 27, 2020

move to int32 for hit indices #583

move to int32 for hit indices #583

Conversation

VinInn commented Nov 25, 2020

fwyzard commented Nov 26, 2020 • edited Loading

Validation summary

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Logs

fwyzard commented Nov 27, 2020

fwyzard commented Nov 27, 2020

VinInn commented Nov 27, 2020

fwyzard commented Nov 27, 2020

master

master + #583

fwyzard commented Nov 26, 2020 •

edited

Loading

logs and `nvprof`/`nvvp` profiles