Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cabling map files for PR#31721 #578

Conversation

tsusa
Copy link

@tsusa tsusa commented Nov 23, 2020

PR description:

Addresses comments about FedCablingMap files migration at PR#31721

PR validation:

The code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

@fwyzard
Copy link

fwyzard commented Nov 24, 2020

@tsusa mhm, the code might compile, but its dependencies do not.

As far as I can see

  • you did not update the include guards in the header files
  • you did not propagate the changes of header files to the files that include them

@fwyzard
Copy link

fwyzard commented Nov 24, 2020

#582 includes these changes, with the necessary updates to the #include statements and header guards.

@fwyzard fwyzard closed this Nov 24, 2020
fwyzard pushed a commit that referenced this pull request Nov 27, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
fwyzard added a commit that referenced this pull request Nov 27, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to
  - CondFormats/SiPixelObjects/
  - CalibTracker/SiPixelESProducers/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pixels Pixels-related developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants