Move common ESProducer templates to ConvertingESProducer(WithDependencies)T #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
added
enhancement
ECAL
makortel
reviewed
Nov 12, 2020
There was a problem hiding this comment.
I can't place comments for ConvertingESProducerWithDependenciesT.h so I do it here
- It is still using
edm::ESTransientHandle - The constructor could construct
std::vector<edm::ESInputTag>directly instead ofstd::vector<std::string> - I'm a bit concerned that the
label<N>parameters can be(come) confusing, on the other hand this could be good enough to support current use cases
fwyzard
force-pushed
the
move_common_templates_to_ConvertingESProducer
branch
2 times, most recently
from
d7bea75
to
23404b3
Compare
…cies)T Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
force-pushed
the
move_common_templates_to_ConvertingESProducer
branch
from
23404b3
to
e238b29
Compare
makortel
approved these changes
Nov 12, 2020
fwyzard
added a commit
that referenced
this pull request
Nov 12, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
added a commit
that referenced
this pull request
Nov 12, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
added a commit
that referenced
this pull request
Nov 16, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
added a commit
that referenced
this pull request
Nov 16, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
added a commit
that referenced
this pull request
Nov 26, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
added a commit
that referenced
this pull request
Nov 26, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
…cies)T (#569) Move few similar implementations of templated ESProducers - EcalESProducerGPU - EcalRawESProducerGPU - HcalESProducerGPU - HcalESProducerGPUWithDependencies - HcalRawESProducerGPU to a common implementation under HeterogeneousCore/CUDACore/ . Adapt all client code accordingly. Do not use transient handles to avoid ESProducers taking references to transient memory objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move few similar implementations of templated ESProducers
to a common implementation under HeterogeneousCore/CUDACore/ .
Adapt all client code accordingly.