Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix max track size in vertex soa #499

Merged
merged 1 commit into from
Jul 7, 2020
Merged

fix max track size in vertex soa #499

merged 1 commit into from
Jul 7, 2020

Conversation

VinInn
Copy link

@VinInn VinInn commented Jul 5, 2020

makes it consistent with the buffer in track soa

the message

%MSG-w PixelVertexProducer:  PixelVertexProducerFromSoA:pixelVertices  05-Jul-2020 17:43:34 CEST Run: 323775 Event: 33111938
oops track 16452 does not exists on CPU 65535
%MSG

should not appear any more (and does not in my test)

@VinInn VinInn added bug-fix fixed Pixels Pixels-related developments labels Jul 5, 2020
@fwyzard fwyzard mentioned this pull request Jul 6, 2020
Closed
@fwyzard fwyzard changed the base branch from master to CMSSW_11_1_X_Patatrack July 6, 2020 09:23
@fwyzard
Copy link

fwyzard commented Jul 6, 2020 •
edited
Loading

@VinInn could you update the PR based on the CMSSW_11_1_X_Patatrack branch, instead of the master branch ?

Something like

git cms-remote add cms-patatrack
git checkout cms-patatrack/CMSSW_11_1_X_Patatrack -b working_branch
git cherry-pick my-cmssw/FixMXTinVS
git push my-cmssw +HEAD:FixMXTinVS

should do it.

@fwyzard
Copy link

fwyzard commented Jul 7, 2020 •
edited
Loading

Validation summary

Reference release CMSSW_11_1_0_pre8 at c8dc5a26005e
Development branch cms-patatrack/CMSSW_11_1_X_Patatrack at 2b28e63
Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 11634.5
  • tracking validation plots and summary for workflow 11634.501
  • tracking validation plots and summary for workflow 11634.502
  • tracking validation plots and summary for workflow 11634.511
  • tracking validation plots and summary for workflow 11634.512

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 11634.5
  • tracking validation plots and summary for workflow 11634.501
  • tracking validation plots and summary for workflow 11634.502
  • tracking validation plots and summary for workflow 11634.511
  • tracking validation plots and summary for workflow 11634.512

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 11634.5
  • tracking validation plots and summary for workflow 11634.501
  • tracking validation plots and summary for workflow 11634.502
  • tracking validation plots and summary for workflow 11634.511
  • tracking validation plots and summary for workflow 11634.512

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png
zoom-136.885502.png
scan-136.885512.png
zoom-136.885512.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 11634.5
  • development release, workflow 11634.5
  • development release, workflow 11634.501
  • development release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 11634.511
  • development release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • testing release, workflow 11634.5
  • testing release, workflow 11634.501
  • testing release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 11634.511
  • testing release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 11634.5
  • development release, workflow 11634.5
  • development release, workflow 11634.501
  • development release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 11634.511
  • development release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • testing release, workflow 11634.5
  • testing release, workflow 11634.501
  • testing release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 11634.511
  • testing release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 11634.5
  • development release, workflow 11634.5
  • development release, workflow 11634.501
  • development release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 11634.511
  • development release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • testing release, workflow 11634.5
  • testing release, workflow 11634.501
  • testing release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 11634.511
  • testing release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/9d58fe618e01831b77469e060538188b0f5d40bc/log .

@fwyzard fwyzard merged commit 65320b0 into cms-patatrack:CMSSW_11_1_X_Patatrack Jul 7, 2020
fwyzard pushed a commit that referenced this pull request Oct 8, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
aaac287 
Make the size consistent with the buffer in track SoA.
@fwyzard fwyzard mentioned this pull request Oct 8, 2020
Merged
fwyzard pushed a commit that referenced this pull request Oct 20, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
c459fea 
Make the size consistent with the buffer in track SoA.
fwyzard pushed a commit that referenced this pull request Oct 23, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
756d856 
Make the size consistent with the buffer in track SoA.
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
866e249 
Make the size consistent with the buffer in track SoA.
@fwyzard fwyzard mentioned this pull request Nov 6, 2020
Merged
fwyzard pushed a commit that referenced this pull request Nov 6, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
6d0e935 
Make the size consistent with the buffer in track SoA.
fwyzard pushed a commit that referenced this pull request Nov 16, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
803e7ce 
Make the size consistent with the buffer in track SoA.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Fix max track size in vertex SoA (#499)
fd9149a 
Make the size consistent with the buffer in track SoA.
fwyzard added a commit that referenced this pull request Dec 26, 2020
@fwyzard
Fix max track size in vertex SoA (#499)
4b5d8ab 
Make the size consistent with the buffer in track SoA.
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
693fdd7 
Make the size consistent with the buffer in track SoA.
fwyzard pushed a commit that referenced this pull request Jan 13, 2021
@cmsbuild @fwyzard
Fix max track size in vertex SoA (#499)
b338157 
Make the size consistent with the buffer in track SoA.
fwyzard pushed a commit that referenced this pull request Jan 15, 2021
@VinInn @fwyzard
Fix max track size in vertex SoA (#499)
c6577b3 
Make the size consistent with the buffer in track SoA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix fixed Pixels Pixels-related developments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinInn @fwyzard