Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries #489

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries #489

merged 3 commits into from
Jun 18, 2020

Conversation

makortel
Copy link

PR description:

Should fix the duplicate dictionary errors reported in cms-sw#27983 (comment)
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28630/7161/dupDict/dup.txt

PR validation:

Code compiles.

@fwyzard
Copy link

fwyzard commented Jun 18, 2020 •
edited
Loading

Validation summary

Reference release CMSSW_11_1_0_pre8 at 442ae07
Development branch cms-patatrack/CMSSW_11_1_X_Patatrack at 4a3813b
Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.501
  • tracking validation plots and summary for workflow 10824.502
  • tracking validation plots and summary for workflow 10824.511
  • tracking validation plots and summary for workflow 10824.512

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.501
  • tracking validation plots and summary for workflow 10824.502
  • tracking validation plots and summary for workflow 10824.511
  • tracking validation plots and summary for workflow 10824.512

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 10824.5
  • tracking validation plots and summary for workflow 10824.501
  • tracking validation plots and summary for workflow 10824.502
  • tracking validation plots and summary for workflow 10824.511
  • tracking validation plots and summary for workflow 10824.512

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png
zoom-136.885502.png
scan-136.885512.png
zoom-136.885512.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.501
  • development release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 10824.511
  • development release, workflow 10824.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • testing release, workflow 10824.5
  • testing release, workflow 10824.501
  • testing release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 10824.511
  • testing release, workflow 10824.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512

/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.501
  • development release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 10824.511
  • development release, workflow 10824.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • testing release, workflow 10824.5
  • testing release, workflow 10824.501
  • testing release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 10824.511
  • testing release, workflow 10824.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512

/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 10824.5
  • development release, workflow 10824.5
  • development release, workflow 10824.501
  • development release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 10824.511
  • development release, workflow 10824.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • testing release, workflow 10824.5
  • testing release, workflow 10824.501
  • testing release, workflow 10824.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 10824.511
  • testing release, workflow 10824.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/8c59990e3176963b44ea21b063ba76b1c1f89143/log .

@fwyzard fwyzard added ECAL ECAL-related developments HCAL HCAL-related developments labels Jun 18, 2020
@fwyzard fwyzard merged commit d4191e9 into cms-patatrack:CMSSW_11_1_X_Patatrack Jun 18, 2020
@makortel makortel deleted the patatrackDuplicateDictionaries branch June 18, 2020 13:48
fwyzard added a commit that referenced this pull request Oct 7, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
c53b86c 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Oct 8, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
8f45e00 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Oct 8, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
25752d3 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Oct 8, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
047a600 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
This was referenced Oct 8, 2020
Merged
Merged
fwyzard added a commit that referenced this pull request Nov 9, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
9720dc2 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 9, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
e7c65f7 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 12, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
4064372 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 12, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
4629448 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 16, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
0c9f262 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 16, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
addfc02 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 26, 2020
@fwyzard
Remove duplicate dictionary definitions (#489)
45f65e9 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Nov 26, 2020
@fwyzard
Remove duplicate dictionary definitions (#489)
aa8fb93 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Remove duplicate dictionary definitions (#489)
e0b0a76 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
fwyzard added a commit that referenced this pull request Dec 29, 2020
@makortel @fwyzard
Remove duplicate dictionary definitions (#489)
167fd46 
Remove dictionary definitions for classes already defined in CUDADataFormats/StdDictionaries.

Co-authored-by: Andrea Bocci <andrea.bocci@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ECAL ECAL-related developments HCAL HCAL-related developments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makortel @fwyzard