Ecal Uncalibrated RecHit GPU format convertor to CPU format #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
requested changes
Jun 25, 2019
RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitConvertGPU2CPUFormat.cc
Outdated
Show resolved
Hide resolved
RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitConvertGPU2CPUFormat.cc
Outdated
Show resolved
Hide resolved
...I actually like comments... |
fwyzard
approved these changes
Jun 26, 2019
|
As expected, comparing the GPU results in SoA format with the same results converted to legacy format yields identical results. |
makortel
reviewed
Jun 26, 2019
| , recHitsLabelCPUEE_{ps.getParameter<std::string>("recHitsLabelCPUEE")} | ||
| { | ||
| produces<EBUncalibratedRecHitCollection>(recHitsLabelCPUEB_); | ||
| produces<EEUncalibratedRecHitCollection>(recHitsLabelCPUEE_); |
There was a problem hiding this comment.
EDPutTokens would allow avoiding string members.
| { | ||
| edm::Handle<ecal::SoAUncalibratedRecHitCollection> hRecHitsGPUEB, hRecHitsGPUEE; | ||
| event.getByToken(recHitsGPUEB_, hRecHitsGPUEB); | ||
| event.getByToken(recHitsGPUEE_, hRecHitsGPUEE); |
There was a problem hiding this comment.
The handles can be avoided with
auto const& recHitsGPUEB = event.get(recHitsGPUEB_);
auto const& recHitsGPUEE = event.get(recHitsGPUEE_);
fwyzard
pushed a commit
that referenced
this pull request
Sep 11, 2019
Update master branch to 10_6_0
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
fwyzard
pushed a commit
that referenced
this pull request
Nov 9, 2020
fwyzard
pushed a commit
that referenced
this pull request
Nov 12, 2020
fwyzard
pushed a commit
that referenced
this pull request
Nov 16, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
EDMProducer to convert from the GPU data format to CPU.