Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize CUDAScopedContext #355

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Reorganize CUDAScopedContext #355

merged 3 commits into from
Jun 20, 2019

Commits on Jun 14, 2019

  1. Split CUDAScopedContext to *Acquire and *Produce 

    Motivation is that the acquire() and produce() need a different
functionality, and are constructed differently (e.g. acquire version
always needs the edm::WaitingTaskWithArenaHolder). This split should
make it more difficult to make mistakes. It should also make future
evolution, e.g. towards chains of TBB tasks alternating in CPU and GPU
work, easier.
    @makortel
    makortel committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    43d3f60 View commit details
    Browse the repository at this point in the history

  2. Rename CUDAContextToken to CUDAContextState, and change semantics 

    Now CUDAScopedContextAcquire takes it as a parameter to constructor,
and stores the state in its destructor (yielding RAII semantics).
    @makortel
    makortel committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    48819a2 View commit details
    Browse the repository at this point in the history

  3. Document constructors

    @makortel
    makortel committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    91ec257 View commit details
    Browse the repository at this point in the history