Configurable doublets and vertex clusterizer #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
force-pushed
the
ForReview_10_6_0_pre2
branch
from
bd977e4
to
25ac5c9
Compare
felicepantaleo
changed the title
fwyzard
force-pushed
the
ForReview_10_6_0_pre2
branch
from
25ac5c9
to
6a2fc95
Compare
|
Please find a version with conflicts fixed at cms-patatrack/pull-342 . |
fwyzard
reviewed
May 10, 2019
| @@ -17,8 +17,6 @@ class SiPixelGainCalibrationForHLTGPU { | |||
| ~SiPixelGainCalibrationForHLTGPU(); | |||
|
|
|||
| const SiPixelGainForHLTonGPU *getGPUProductAsync(cuda::stream_t<>& cudaStream) const; | |||
| const SiPixelGainForHLTonGPU *getCPUProduct() const { return gainForHLTonHost_;} | |||
| const SiPixelGainCalibrationForHLT *getOriginalProduct() { return gains_;} | |||
There was a problem hiding this comment.
In fact, are you suggesting to drop all of 0f57c78 ?
|
From the validation, I see some non-negligible (?) changes to the .52 workflows:
RelValZMM_13
What is "development" here ? |
fwyzard
force-pushed
the
ForReview_10_6_0_pre2
branch
16 times, most recently
from
0ddd4d4
to
41cd273
Compare
fwyzard
force-pushed
the
ForReview_10_6_0_pre2
branch
from
0aa4190
to
c00ea91
Compare
|
replaced by #347 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.