Remove redundant CUDA event occurred checks #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call is already part of CUDAProduct::isAvailable().
VinInn
reviewed
Apr 23, 2019
|
... and forcing to check again by changing the target branch does not seem to help here. |
fwyzard
pushed a commit
that referenced
this pull request
May 15, 2019
L1 unprefireable bit + MET covariance/significance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR removes redundant calls to
cuda::event_t::has_occurred()when it is called in conjunction withCUDAProduct::isAvailable(). The former are redundant becauseisAvailable()already callshas_occurred().Also fix (interim part in)
SiPixelRecHitHeterogeneousto use the CUDA event of the correct product when callingcudaStreamWaitEvent().Thanks to @VinInn for noticing.
PR validation:
Profiling workflow runs, unit tests run.