make gpu-cpu cluster matching deterministic #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinInn
changed the title
fwyzard
requested changes
Mar 21, 2019
| @@ -196,7 +197,10 @@ class SiPixelCluster { | |||
| float getSplitClusterErrorX() const { return err_x; } | |||
| float getSplitClusterErrorY() const { return err_y; } | |||
|
|
|||
|
|
|||
| // the original id (they get sorted) | |||
| auto oriId() const { return theClusId;} | |||
There was a problem hiding this comment.
can we call these originalId() and setOriginalId() ?
| @@ -207,6 +211,8 @@ class SiPixelCluster { | |||
| uint16_t theMinPixelCol=MAXPOS; // Minimum pixel index in the y direction (left edge). | |||
| uint8_t thePixelRowSpan=0; // Span pixel index in the x direction (low edge). | |||
| uint8_t thePixelColSpan=0; // Span pixel index in the y direction (left edge). | |||
|
|
|||
| uint16_t theClusId=std::numeric_limits<uint16_t>::max(); | |||
|
Thanks, I will rebuild at flatiron and run the usual checks... then it sounds like a good reason to cut the next release. |
|
ok, I will edit here, my area is still compiling and this changes will trigger full recompilation again... |
|
modified, recompiled, tested, committed, pushed |
makortel
reviewed
Mar 21, 2019
RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu
Show resolved
Hide resolved
|
No impact on the throughput (as expected), running on a P100: |
Validation summaryReference release CMSSW_10_5_0_pre2 at 4fd4ff5
|
fwyzard
approved these changes
Mar 21, 2019
|
No changes in physics performance observed (as expected). |
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Oct 19, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Oct 20, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Oct 23, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Nov 6, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Nov 16, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
added a commit
that referenced
this pull request
Nov 27, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
Makes the GPU-CPU cluster matching deterministic by intrusively marking CPU clusters with the cluster index. Reuse existing padding space to store the extra transient field, so that the size of SiPixelCluster does not increase. There is still a warning in case of mismatch of the content of the cluster (based on charge comparison), that can eventually be downgraded to a debug message. Properly rewrite the loop in the RawToDigi_kernel . Remove obsolete code (comments and configuration parameters) in SiPixelRawToClusterCUDA and SiPixelRawToClusterGPUKernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs makes gpu-cpu cluster matching deterministic by intrusively marking CPU clusters with the cpu cluster index.
The size of SiPixelCluster does not increase neither in memory nor on disk (there was a 16 byte padding space that came handy...)
Obsolete code (comments and config param) in Raw2Cluster removed.
Took the opportunity to properly write the loop in the kernel
Recompiles a bit more than the whole universe: not something you want to carry on in your development area too long
minor regression expected (not in the GPU results, at most in TP matching).
There is still a warning in case of mismatch of the content of the cluster (based on charge comparison).
can be downgraded to debug