Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or disable failing unit tests #253

Merged

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Jan 18, 2019

No description provided.

@fwyzard
Copy link
Author

fwyzard commented Jan 18, 2019

@VinInn, I have disabled HeterogeneousCore/CUDAUtilities/test/HistoContainer_t.cpp that fails with

===== Test "HistoContainer_t" ====
HistoContainer 7 128 129 12000 511
bins 0 64 63
HistoContainer4 7 128 513 12000 511
bins 0 64 63
bins 128 192 191
bins 256 320 319
bins 384 448 447
HistoContainer_t: /mnt/home/fwyzard/patatrack/CMSSW_10_4_0_Patatrack/src/HeterogeneousCore/CUDAUtilities/interface/HistoContainer.h:290: void HistoContainer<T, NBINS, SIZE, S, I, NHISTS>::fill(T, HistoContainer<T, NBINS, SIZE, S, I, NHISTS>::index_type, uint32_t) [with T = short int; unsigned int NBINS = 128; unsigned int SIZE = 12000; unsigned int S = 16; I = short unsigned int; unsigned int NHISTS = 4; HistoContainer<T, NBINS, SIZE, S, I, NHISTS>::index_type = short unsigned int; uint32_t = unsigned int]: Assertion `w>0' failed.
/bin/sh: line 1: 362980 Aborted                 (core dumped) HistoContainer_t

Please let me know if it should be removed, or make a PR to fix it.

@fwyzard fwyzard merged commit 02e8954 into cms-patatrack:CMSSW_10_4_X_Patatrack Jan 18, 2019
@fwyzard fwyzard deleted the patatrack_fix_unit_tests branch January 18, 2019 16:04
@VinInn
Copy link

VinInn commented Jan 21, 2019

I have a fix

diff --git a/HeterogeneousCore/CUDAUtilities/test/HistoContainer_t.cpp b/HeterogeneousCore/CUDAUtilities/test/HistoContainer_t.cpp
index c61a5004f8b..d165c3232f5 100644
--- a/HeterogeneousCore/CUDAUtilities/test/HistoContainer_t.cpp
+++ b/HeterogeneousCore/CUDAUtilities/test/HistoContainer_t.cpp
@@ -46,7 +46,7 @@ void go() {
     h.finalize(); h4.finalize();
     assert(h.size()==N);
     assert(h4.size()==N);
-    for (long long j = 0; j < N; j++) { h.fill(v[j],j);  if(j<2000) h4.fill(v[j],2); else h4.fill(v[j],j,j%4); }
+    for (long long j = 0; j < N; j++) { h.fill(v[j],j);  if(j<2000) h4.fill(v[j],j,2); else h4.fill(v[j],j,j%4); }
     assert(h.off[0]==0);
     assert(h4.off[0]==0);
     assert(h.size()==N);

will make a PR soon. (tested in an old area)

fwyzard added a commit that referenced this pull request Oct 8, 2020
fwyzard added a commit that referenced this pull request Oct 19, 2020
fwyzard added a commit that referenced this pull request Oct 20, 2020
fwyzard added a commit that referenced this pull request Oct 23, 2020
fwyzard added a commit that referenced this pull request Nov 6, 2020
fwyzard added a commit that referenced this pull request Nov 16, 2020
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
fwyzard added a commit that referenced this pull request Dec 29, 2020
fwyzard added a commit that referenced this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants