Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary pragmas #249

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Remove unnecessary pragmas #249

merged 1 commit into from
Jan 17, 2019

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Jan 17, 2019

#pragma unroll is not supported by GCC, leading to compilation warnings in host code.
GCC 8 supports #pragma GCC unroll N which could be used instead.

However, benchmarking on a V100 with and without the #pragma unroll there is no observable difference, so it is simpler to remove them.

@fwyzard
Remove ineffective pragmas
258955d 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
@fwyzard
Copy link
Author

fwyzard commented Jan 17, 2019

No observable impact on the performance: 1868.2 ± 3.8 ev/s (before) vs 1870.8 ± 5.4 ev/s (after).

@fwyzard fwyzard merged commit 6218478 into cms-patatrack:CMSSW_10_4_X_Patatrack Jan 17, 2019
@fwyzard fwyzard deleted the patatrack_remove_unroll branch January 17, 2019 07:32
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Remove unnecessary pragmas (#249)
7f1fe82 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
@fwyzard fwyzard mentioned this pull request Oct 8, 2020
Merged
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Remove unnecessary pragmas (#249)
57e344d 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Remove unnecessary pragmas (#249)
93138cc 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Remove unnecessary pragmas (#249)
835538c 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Remove unnecessary pragmas (#249)
676fd50 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Remove unnecessary pragmas (#249)
b527b60 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Remove unnecessary pragmas (#249)
ef1f655 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Remove unnecessary pragmas (#249)
08e88cf 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard pushed a commit that referenced this pull request Dec 26, 2020
@cmsbuild @fwyzard
Remove unnecessary pragmas (#249)
2314e4c 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
@fwyzard fwyzard mentioned this pull request Dec 26, 2020
Merged
fwyzard added a commit that referenced this pull request Jan 15, 2021
@fwyzard
Remove unnecessary pragmas (#249)
22ff08f 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Mar 23, 2021
@fwyzard
Remove unnecessary pragmas (#249)
adf3f28 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
fwyzard added a commit that referenced this pull request Apr 1, 2021
@fwyzard
Remove unnecessary pragmas (#249)
3deb206 
`#pragma unroll` is not supported by GCC, leading to compilation
warnings in host code.
GCC 8 supports `#pragma GCC unroll N` which could be used instead.

However, benchmarking on a V100 with and without the `#pragma unroll`
there is no observable difference, so it is simpler to remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fwyzard