Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around atomicAdd problem on Volta #180

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Sep 30, 2018

As reported here, atomicAdd() seems to introduce a synchronisation problem; fortunately it seems that atomicInc() is OK.

@fwyzard fwyzard mentioned this pull request Sep 30, 2018
@fwyzard fwyzard added the bug label Sep 30, 2018
@fwyzard
Copy link
Author

fwyzard commented Sep 30, 2018

Validation summary

Reference release CMSSW_10_2_5 at a8a031d
Development branch CMSSW_10_2_X_Patatrack at b5135e6
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_2-PU25ns_102X_upgrade2018_realistic_v11-v2/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_2-102X_upgrade2018_realistic_v11-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/5ffdb2df3fe7e11c424be64ce5ae9b2c0e10b9c8/log .

@fwyzard
Copy link
Author

fwyzard commented Sep 30, 2018

The single crash was due to cudaErrorMemoryAllocation: out of memory because the validation was running too many jobs at the same time...

@fwyzard fwyzard changed the title Work around atomicAdd problem on volta Work around atomicAdd problem on Volta Sep 30, 2018
@fwyzard fwyzard merged commit e269bdd into cms-patatrack:CMSSW_10_2_X_Patatrack Sep 30, 2018
@fwyzard fwyzard added the fixed label Sep 30, 2018
@fwyzard fwyzard self-assigned this Sep 30, 2018
@fwyzard
Copy link
Author

fwyzard commented Sep 30, 2018

@VinInn looking at the validation results, #179 and #180 taken together seem to reduce the number of duplicate tracks. Just a random fluctuation, or do you think it may have actually have improved ?

@fwyzard fwyzard added this to the CMSSW_10_2_6_Patatrack milestone Oct 31, 2018
@fwyzard fwyzard deleted the Work_around_atomicAdd_problem_on_Volta branch January 26, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant