Riemann fit multiple scattering #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation summaryReference release CMSSW_10_2_4 at 6e8f631
|
|
@rovere can you check what broke with the 10824.9 workflow (Riemann fit on GPU) ? |
|
Sure, I'll have a look. |
|
Looking at TTbar Riemann fit workflow on the CPU (10824.7)
|
|
The 10824.9 workflow fails with
114 // LAUNCH THE KERNEL FIT
115 launchKernelFit(hits_and_covariancesGPU, 12*4*total_seeds, 4,
116 bField, helix_fit_resultsGPU);
117 // CUDA MEMCOPY DEVICE2HOST OF HELIX_FIT
118 cudaCheck(cudaDeviceSynchronize());As it is unlikely that the problem is in the |
|
|
|
Yes, I kept them separate |
Validation summaryReference release CMSSW_10_2_4 at 6e8f631 🚧 Validation running at vinavx2.cern.ch:/data/user/fwyzard/patatrack/validation/run.LXXxfUzJi7 ... |
|
This should finally work on the GPU together with #178 and the latest patches to Eigen. |
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Oct 20, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Oct 20, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Oct 23, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Nov 6, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Nov 6, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Nov 16, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
added a commit
that referenced
this pull request
Nov 27, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Dec 26, 2020
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Jan 15, 2021
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Mar 23, 2021
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
fwyzard
pushed a commit
that referenced
this pull request
Apr 1, 2021
Implement the multiple scattering treatments in the Riemann Fit. In particular: - modify the previous implementation of the multiple scattering in the circle fit to correctly cover both the barrel and the forward case; - implement the multiple scattering in the line fit in the S-Z plane both for the barrel and the forward case. The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV. The pulls are ok-ish, the material could be further tuned. The Chi2 is flat on all eta range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the multiple scattering treatments in the Riemann Fit. In particular:
The effective radiation length is still an approximate value since the phi angle is not taken into account (it is not known on a layer-by-layer case). Ad ad-hoc correction based on the inverse of the pt has been added, with a cut-off of 1 GeV.
The pulls are ok-ish, the material could be further tuned.
The Chi2 is flat on all eta range.
The usual MTV collection of plots are available at this link for single muon of pt_1. I verified that the behaviour of the fit is ok-ish also using ttbar and singleMu pt_10.