Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninitialized memory access in GPU CellularAutomaton #127

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Fix uninitialized memory access in GPU CellularAutomaton #127

merged 1 commit into from
Aug 10, 2018

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Aug 9, 2018

Spotted by cuda-memcheck, see e.g. this report.

@fwyzard fwyzard added the bug label Aug 9, 2018
@fwyzard
Copy link
Author

fwyzard commented Aug 9, 2018 •
edited
Loading

Validation summary

Reference release CMSSW_10_2_1 at d00b7b4
Development branch CMSSW_10_2_X_Patatrack at c21bbb7
Testing PRs:

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_1-PU25ns_102X_upgrade2018_realistic_v9_gcc7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_1-102X_upgrade2018_realistic_v9_gcc7-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_1-PU25ns_102X_upgrade2018_realistic_v9_gcc7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_1-102X_upgrade2018_realistic_v9_gcc7-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_1-PU25ns_102X_upgrade2018_realistic_v9_gcc7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_1-102X_upgrade2018_realistic_v9_gcc7-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/112df6a2b4d597bdee36126ba12c9af156ce0f07/log .

@fwyzard
Copy link
Author

fwyzard commented Aug 9, 2018

The crash in 10824.8 is due to an out-of-memory condition, likely due to running too many workflows at the same time.

@fwyzard
Copy link
Author

fwyzard commented Aug 9, 2018

The uninitialized memory read in gpuPixelDoublets::getDoubletsFromHisto is indeed no longer present.
Apparently there remain few in simLink in ClusterSLOnGPU.cu.

This was referenced Aug 9, 2018
Merged
Merged
@fwyzard fwyzard changed the title Fix uninitialized memory access Fix uninitialized memory access in GPU CellularAutomaton Aug 10, 2018
@fwyzard fwyzard merged commit 907e17c into cms-patatrack:CMSSW_10_2_X_Patatrack Aug 10, 2018
@fwyzard fwyzard added this to the CMSSW_10_2_2_Patatrack milestone Aug 14, 2018
@fwyzard fwyzard deleted the fix_uninitialized_memory_access branch August 25, 2018 07:38
@fwyzard fwyzard modified the milestone: CMSSW_10_2_2_Patatrack Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
CMSSW_10_2_2_Patatrack
Development

Successfully merging this pull request may close these issues.
1 participant
@fwyzard