Various fixes and cleanup #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly destroys and cleans up all resources associated with the current device in the destructor of the CUDAService. Useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full
Validation summaryReference release CMSSW_10_2_0_pre6 at a674e1f
|
|
While this does not fix the 10824.8 Zmumu workflow, it should fix some minor bugs and do some clean up - and it does not seem to introduce any regressions. |
|
ok for me.... |
|
+1 |
fwyzard
added a commit
that referenced
this pull request
Oct 8, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Oct 19, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Oct 20, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Oct 23, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Nov 6, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Nov 16, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Fix errors found by cuda-memcheck: - properly initialise device memory - fix various cudaMemcpy calls Remove unused debug variables and function declarations, and #ifdef some debug printouts. Call cudaDeviceReset() before exiting, via the destructor of CUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks with cuda-memcheck --tool memcheck --leak-check full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors found by
cuda-memcheck:cudaMemcpycallsRemove unused debug variables and function declarations, and
#ifdefsome debug printouts.Call
cudaDeviceReset()before exiting, via the destructor ofCUDAService. This explicitly destroys and cleans up all resources associated with the current device, and is useful to check for memory leaks withcuda-memcheck --tool memcheck --leak-check full.