Apply code checks (#315)

cms-patatrack · Apr 9, 2019 · 49f2c7f · 49f2c7f
1 parent a1415e0
commit 49f2c7f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CUDADataFormats/SiPixelDigi/src/SiPixelDigiErrorsCUDA.cc b/CUDADataFormats/SiPixelDigi/src/SiPixelDigiErrorsCUDA.cc
@@ -17,7 +17,7 @@ SiPixelDigiErrorsCUDA::SiPixelDigiErrorsCUDA(size_t maxFedWords, PixelFormatterE
 
   error_h = cs->make_host_unique<GPU::SimpleVector<PixelErrorCompact>>(stream);
   GPU::make_SimpleVector(error_h.get(), maxFedWords, data_d.get());
-  assert(error_h->size() == 0);
+  assert(error_h->empty());
   assert(error_h->capacity() == static_cast<int>(maxFedWords));
 
   cudautils::copyAsync(error_d, error_h, stream);
@@ -35,7 +35,7 @@ SiPixelDigiErrorsCUDA::HostDataError SiPixelDigiErrorsCUDA::dataErrorToHostAsync
   auto data = cs->make_host_unique<PixelErrorCompact[]>(error_h->capacity(), stream);
 
   // but transfer only the required amount
-  if(error_h->size() > 0) {
+  if (not error_h->empty()) {
     cudautils::copyAsync(data, data_d, error_h->size(), stream);
   }
   auto err = *error_h;

diff --git a/HeterogeneousCore/CUDATest/plugins/TestCUDAAnalyzerGPU.cc b/HeterogeneousCore/CUDATest/plugins/TestCUDAAnalyzerGPU.cc
@@ -21,7 +21,7 @@ class TestCUDAAnalyzerGPU: public edm::global::EDAnalyzer<> {
   static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
 
   void analyze(edm::StreamID, const edm::Event& iEvent, const edm::EventSetup& iSetup) const override;
-  void endJob();
+  void endJob() override;
 
 private:
   std::string label_;

diff --git a/HeterogeneousCore/CUDATest/plugins/TestCUDAProducerCPU.cc b/HeterogeneousCore/CUDATest/plugins/TestCUDAProducerCPU.cc
@@ -16,7 +16,7 @@ class TestCUDAProducerCPU: public edm::global::EDProducer<> {
 
   static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
 
-  void produce(edm::StreamID id, edm::Event& iEvent, const edm::EventSetup& iSetup) const;
+  void produce(edm::StreamID id, edm::Event& iEvent, const edm::EventSetup& iSetup) const override;
 private:
   std::string label_;
   edm::EDGetTokenT<int> srcToken_;