-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LowPtElectrons: convert Seed BDTs from XML to ROOT file format #22
LowPtElectrons: convert Seed BDTs from XML to ROOT file format #22
Conversation
A new Pull Request was created by @bainbrid for branch master. @perrotta, @smuzaffar, @iarspider, @mrodozov, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks. |
This PR is used by cms-sw/cmssw#34908 |
+reconstruction for cmsdist this should be merged together with cms-sw/cmssw#34908 |
|
+externals Because of |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
merge |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-INPUT
AddOn Tests
Expand to see more addon errors ... |
Is this #22 (comment) something I need to worry about? Presumably so? Why is it only showing up now? |
because the test has been started, and when the pr was merged the test wasn't stopped. and also because it ran without the corresponding cmssw PR |
This PR converts the formats (from XML to ROOT) of two files containing the weights of two BDT models used by the low pT electron seeding step in the reconstruction chain.
The effect is to reduce the file size by a factor two for both files, and to reduce the memory consumption and CPU time when parsing the weights files.
This was done in response to the issues raised here: cms-sw/cmssw#34707
A similar change was made previously, but on the weights file for the BDT model used by the low pT electron ID module (as opposed to the seeding step, as above), which solved the issues raised here: cms-sw/cmssw#28780