Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONNX models of ParticleNet V00 #33

Merged
merged 3 commits into from
Jul 20, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Jul 8, 2020

This PR adds the ONNX models of ParticleNet V00 and the corresponding preprocessing JSON files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

A new Pull Request was created by @hqucms (Huilin Qu) for branch master.

@perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @jpata, @tulamor can you please review it and eventually sign? Thanks.
@emilbols, @smoortga, @riga, @JyothsnaKomaragiri, @mverzett, @ferencek, @andrzejnovak this is something you requested to watch as well.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30599

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

-1

Tested at: 607f097

CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #30016 @andrzejnovak: Introduce DeepDoubleX V2
  • #30169 @dildick: GE2/1 pads with 16 eta partitions & option to send overflow GEM clusters
  • #30554 @JamminJones: added esConsumes to modules in RecoVertex/BeamSpotProducer
  • #30380 @davidlange6: Add all direct deps to BuildFile for CondFormats/L1TObjects
  • #30283 @JamminJones: added esConsumes to modules in EventFilter/GctRawToDigi
  • #30466 @CTPPS: PPS: direct simulation update A
  • #30565 @camolezi: Reduce boost dependency in FWCore/MessageService
  • #30549 @cms-tsg-storm: Migration of HLT menus to 11_1_0 template (11_2_X)
  • #30421 @JamminJones: added esConsumes to modules in L1Trigger/RegionalCaloTrigger
  • #30469 @JamminJones: added esConsumes to modules in L1Trigger/RPCTechnicalTrigger
  • #30541 @jbsauvan: [HGC trigger] Replace exception with warning for missing wafer in module mapping
  • #30427 @JamminJones: added esConsumes to modules in L1Trigger/L1TGlobal
  • #30336 @JamminJones: added esConsumes to modules in L1Trigger /L1ExtraFromDigis
  • #30356 @swozniewski: fix typo in provenance access by L1TTauOffline
  • #30448 @MilanoBicocca-pix: BeamSpotOnline in DQM beamspot clients
  • #30449 @camolezi: Reduce boost dependency in OnlineDB/EcalCondDB
  • #30447 @PFCal-dev: [HGC trigger] Clean deprecated files
  • #29932 @fwyzard: Apply missed clang-tidy checks
  • #30500 @bsunanda: Run3-hcx261 Update the material budget study code for HCAL
  • #30486 @bsunanda: Phase2-hgx251 Add the algorithm for next version of HGCal geometry description
  • #30394 @davidlange6: Add all direct deps to BuildFile for L1Trigger/L1TNtuples
  • #30393 @davidlange6: Add all direct deps to BuildFile for L1Trigger/L1TGlobal
  • #30472 @JamminJones: added esConsumes to modules in L1Trigger/RPCTrigger
  • #30358 @JamminJones: added esConsumes to modules in L1Trigger/GlobalTrigger
  • #30526 @bsunanda: Run3-gem42 Remove reference to GE21 from Run3 scenario
  • #30567 @makortel: Remove obsolete files from FWCore/Framework/doc
  • #30418 @davidlange6: Add all direct deps to BuildFile for SimTracker/TrackTriggerAssociation
  • #30434 @JamminJones: added esConsumes to modules in L1Trigger/L1TTwinMux
  • #30433 @JamminJones: added esConsumes to modules in L1Trigger/L1TCalorimeter
  • #30431 @JamminJones: added esConsumes to modules in L1Trigger/L1TMuon
  • #30345 @JamminJones: added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi
  • #30072 @jmduarte: ONNX-based Higgs to bb Interaction Network Tagger
  • #30348 @JamminJones: added esConsumes to modules in L1Trigger/GlobalCaloTrigger
  • #30534 @bsunanda: Run4-hgx251 Small update to the code
  • #30104 @dildick: Rewrite ALCT trigger patterns as 2D vector (ACLUT-2)
  • #30103 @dildick: CLCT comparator code calculation (CCLUT-5)
  • #30360 @JamminJones: added esConsumes to modules in L1Trigger/GlobalMuonTrigger

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7786/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7786/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7786/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #30016 @andrzejnovak: Introduce DeepDoubleX V2
  • #30169 @dildick: GE2/1 pads with 16 eta partitions & option to send overflow GEM clusters
  • #30554 @JamminJones: added esConsumes to modules in RecoVertex/BeamSpotProducer
  • #30380 @davidlange6: Add all direct deps to BuildFile for CondFormats/L1TObjects
  • #30283 @JamminJones: added esConsumes to modules in EventFilter/GctRawToDigi
  • #30466 @CTPPS: PPS: direct simulation update A
  • #30565 @camolezi: Reduce boost dependency in FWCore/MessageService
  • #30549 @cms-tsg-storm: Migration of HLT menus to 11_1_0 template (11_2_X)
  • #30421 @JamminJones: added esConsumes to modules in L1Trigger/RegionalCaloTrigger
  • #30469 @JamminJones: added esConsumes to modules in L1Trigger/RPCTechnicalTrigger
  • #30541 @jbsauvan: [HGC trigger] Replace exception with warning for missing wafer in module mapping
  • #30427 @JamminJones: added esConsumes to modules in L1Trigger/L1TGlobal
  • #30336 @JamminJones: added esConsumes to modules in L1Trigger /L1ExtraFromDigis
  • #30356 @swozniewski: fix typo in provenance access by L1TTauOffline
  • #30448 @MilanoBicocca-pix: BeamSpotOnline in DQM beamspot clients
  • #30449 @camolezi: Reduce boost dependency in OnlineDB/EcalCondDB
  • #30447 @PFCal-dev: [HGC trigger] Clean deprecated files
  • #29932 @fwyzard: Apply missed clang-tidy checks
  • #30500 @bsunanda: Run3-hcx261 Update the material budget study code for HCAL
  • #30486 @bsunanda: Phase2-hgx251 Add the algorithm for next version of HGCal geometry description
  • #30394 @davidlange6: Add all direct deps to BuildFile for L1Trigger/L1TNtuples
  • #30393 @davidlange6: Add all direct deps to BuildFile for L1Trigger/L1TGlobal
  • #30472 @JamminJones: added esConsumes to modules in L1Trigger/RPCTrigger
  • #30358 @JamminJones: added esConsumes to modules in L1Trigger/GlobalTrigger
  • #30526 @bsunanda: Run3-gem42 Remove reference to GE21 from Run3 scenario
  • #30567 @makortel: Remove obsolete files from FWCore/Framework/doc
  • #30418 @davidlange6: Add all direct deps to BuildFile for SimTracker/TrackTriggerAssociation
  • #30434 @JamminJones: added esConsumes to modules in L1Trigger/L1TTwinMux
  • #30433 @JamminJones: added esConsumes to modules in L1Trigger/L1TCalorimeter
  • #30431 @JamminJones: added esConsumes to modules in L1Trigger/L1TMuon
  • #30345 @JamminJones: added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi
  • #30072 @jmduarte: ONNX-based Higgs to bb Interaction Network Tagger
  • #30348 @JamminJones: added esConsumes to modules in L1Trigger/GlobalCaloTrigger
  • #30534 @bsunanda: Run4-hgx251 Small update to the code
  • #30104 @dildick: Rewrite ALCT trigger patterns as 2D vector (ACLUT-2)
  • #30103 @dildick: CLCT comparator code calculation (CCLUT-5)
  • #30360 @JamminJones: added esConsumes to modules in L1Trigger/GlobalMuonTrigger

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7786/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7786/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7786/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3258 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787356
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787271
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30599

@cmsbuild
Copy link
Contributor

+1
Tested at: 607f097
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/7903/summary.html
CMSSW: CMSSW_11_2_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #33 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30599

@cmsbuild
Copy link
Contributor

+1
Tested at: b5531db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/8013/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f12d9/8013/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612943
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612894
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 146 log files, 17 edm output root files, 35 DQM output files

@slava77
Copy link

slava77 commented Jul 17, 2020

+1

based on tests with cms-sw/cmssw#30599
if it helps the cms-sw PR integration, this PR can be merged and added to the release first

@mrodozov
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants