Resolves noreply.org issue for Location.py #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpaul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves two outstanding issues.
First, it replaces the now defunct noreply.org with IPify as suggested by @abhidg. Per IPIfy's code samples, this solution uses the Requests library, which has been added to setup.py.
I also commented out some code in __init.py__ that looked like it was a place marker for future development. The problem was this code forced Location.py results to the top of the commit message. Expected behavior is that plugin results end up in the commit message in the order they're placed in the Flashbake config file.
If the pull request is accepted then issues #33 and #35 should be closed.