Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent xns cancellation propagation on worker close #68

Merged
merged 1 commit into from
May 14, 2024
Merged

Prevent xns cancellation propagation on worker close #68

merged 1 commit into from
May 14, 2024

Conversation

cludden
Copy link
Owner

@cludden cludden commented May 13, 2024 •
edited
Loading

Changes

  • listen for worker stop and returns retryable application error
  • double checks worker stop channel before propagating cancellation on activity context cancellation
  • honor workflow parent_close_policy in xns workflow activities
  • allow overriding default parent_close_policy for xns workflow activities via xns.parent_close_policy workflow option
  • allow setting explicit ParentClosePolicy at runtime via WithParentClosePolicy option

@cludden cludden added the bug Something isn't working label May 13, 2024
@cludden cludden force-pushed the cludden/xns-cancellation-fix branch 4 times, most recently from 62f64d4 to 78b68eb Compare May 14, 2024 16:23
@cludden cludden force-pushed the cludden/xns-cancellation-fix branch from 78b68eb to 8cc56d9 Compare May 14, 2024 16:29
@cludden cludden marked this pull request as ready for review May 14, 2024 16:34
@cludden cludden merged commit b7a15c4 into main May 14, 2024
1 check passed
@cludden cludden deleted the cludden/xns-cancellation-fix branch May 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cludden