Fix KMS lookup for Python2 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of implicitly getting an ASCII bytestring, Explicitly get an UTF-8 bytestring. Don't try to decode anything afterwards. Resolves this error: ``` 'ascii' codec can't decode byte 0xcb in position 5: ordinal not in range(128)) ``` modified: stacker/lookups/handlers/kms.py modified: stacker/tests/lookups/handlers/test_kms.py
|
Verified to fix the issue found at @ Remind |
ejholmes
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
Change looks fine to me, but probably hold off on merging until @phobologic has had a chance to review. I don't really understand why explicitly encoding to utf-8 is necessary in 1.4, and not in 1.3, so I'm not sure if this would be better done in another location (like, should the entire parsed template be explicitly encoded to utf-8?)
|
I suppose it isn't necessary to be explicit but that's how the this bug crept in. The trailing |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
…unicode Fix KMS lookup for Python2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly get an UTF-8 bytestring but don't try to decode anything afterwards.
Resolves this error: