Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a lookup for system environment variables. #418

Merged
merged 3 commits into from
Jun 25, 2017

Conversation

jesse-peters
Copy link
Contributor

Goes with issue #352

Adds the ability to use environment variables as a lookup.

@codecov
Copy link

codecov bot commented Jun 25, 2017

Codecov Report

Merging #418 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   88.55%   88.62%   +0.06%     
==========================================
  Files          87       89       +2     
  Lines        4518     4544      +26     
==========================================
+ Hits         4001     4027      +26     
  Misses        517      517
Impacted Files Coverage Δ
stacker/lookups/handlers/envvar.py 100% <100%> (ø)
stacker/lookups/registry.py 94.87% <100%> (+0.27%) ⬆️
stacker/tests/lookups/handlers/test_envvar.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30751af...be9b91c. Read the comment docs.

@phobologic
Copy link
Member

Thanks @syphon7 - did some minor cleanup, and threw a doc in the PR. This is great!

@phobologic phobologic merged commit bd66467 into cloudtools:master Jun 25, 2017
This was referenced Jul 6, 2017
phrohdoh pushed a commit to phrohdoh/stacker that referenced this pull request Dec 18, 2018
Added a lookup for system environment variables.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants