-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Moving configuration and auth logic #37
Conversation
969a6a2
to
b3bbc69
Compare
This is being moged from cloudquery/cli to allow it to be shared by both the `plugin-sdk` and `cloudquery/cli` components. fixes: cloudquery/cloudquery-issues#668
b3bbc69
to
f1309cf
Compare
f1309cf
to
a6df06a
Compare
@@ -0,0 +1,8 @@ | |||
.PHONY: test | |||
test: | |||
go test -tags=assert -race ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-tags=assert
is for Arrow tests, we don't need this I think... just fyi :) (still it could be beneficial to keep it...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I wasn't quite sure what that was for. Good to know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good call, let's remove it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed the request - follow up here
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.9...v1.3.0) (2023-10-17) ### Features * Moving configuration and auth logic ([#37](#37)) ([0bffdb2](0bffdb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This is being moved from cloudquery/cli to allow it to be shared by both the
plugin-sdk
andcloudquery/cli
components.This may not be the best place for this code in the long run, but for now we want to share the code between
cloudquery/cli
andplugin-sdk
without havingcloudquery/cli
introduce a dependency on theplugin-sdk
.This PR also modifies the token issuing logic, to only refresh the ID token if the existing token is close to expiry. This is to minimise the API calls needed during the sync upsert process.