Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform cloudposse/s3-log-storage/aws to v0.28.3 (release/v0) - abandoned #86

Open
wants to merge 3 commits into
base: release/v0
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 1, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-log-storage/aws (source) module minor 0.26.0 -> 0.28.3

Release Notes

cloudposse/terraform-aws-s3-log-storage (cloudposse/s3-log-storage/aws)

v0.28.3: Not recommended, use v0.26.0 or v1.x instead

Compare Source

Update: This version no longer recommended

With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v3 @​renovate (#​78)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module major 2.0.1 -> 3.0.0

v0.28.2: Action required if updating from prior to v0.28.0

Compare Source

Update: This version no longer recommended

With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.

v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.

We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v2.0.1 @​renovate (#​76)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 2.0.0 -> 2.0.1

v0.28.1: accidental release, do not use

Compare Source

v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.

We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.

git.io->cloudposse.tools update @​dylanbannon (#​73)

what and why

Change all references to git.io/build-harness into cloudposse.tools/build-harness, since git.io redirects will stop working on April 29th, 2022.

References

  • DEV-143

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v2 @​renovate (#​72)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module major 0.49.0 -> 2.0.3

v0.28.0: (Action Needed) Support AWS v4 provider

Compare Source

WARNING, DATA LOSS LIKELY if you do not follow upgrade instructions:

🚀 Enhancements

Support AWS v4 provider @​Nuru (#​71)

what

  • Migrate to AWS v4 Terraform provider
  • Add features
    • Allow full S3 storage lifecycle configuration
    • Allow multiple bucket policy documents
    • Allow specifying the bucket name directly, rather than requiring it to be generated by null-label
    • Allow specifying S3 object ownership
    • Allow enabling S3 bucket keys for encryption
  • Deprecate variable by variable specification of a single storage lifecycle rule
  • Add extra safety measure force_destroy_enabled

why

  • AWS v4 broke this module
  • Feature parity
  • Replaced with more power and more flexible input
  • Reduce the chance that automated upgrades will cause data loss

references

v0.27.0: (WARNING: Potential Data Loss) Prepare for AWS provider v4

Compare Source

Update: This version no longer recommended

With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.

Warning: Potential total data loss

This release is a refactoring in preparation for supporting Terraform AWS Provider v4. One feature was removed, but otherwise there are no changes to inputs or behavior. However, the Terraform "addresses" of resources have changed, so you are need to run several terraform state mv commands.

Warning: failure to run the required terraform state mv commands will cause Terraform to delete your existing S3 bucket and create a new one, deleting all the data stored in the bucket in the process.

Details on how to safely upgrade are in this repository's Wiki here

Support for "MFA delete" removed

In #​54 a contributor added support for MFA delete via the versioning_mfa_delete_enabled. In AWS provider version 3.x this argument was documented with the caveat

This cannot be used to toggle this setting but is available to allow managed buckets to reflect the state in AWS.

With AWS provider version 4.0, this argument now does toggle the setting. Unfortunately, that adds the requirement then when it is enabled, you must supply a current MFA token every time you run terraform apply. That is not compatible with automation, and therefore we have no intention to support it and have removed the versioning_mfa_delete_enabled input.

🚀 Enhancements

Refactor to use s3-bucket module, update in general @​Nuru (#​66)

what

  • Refactor to use terraform-aws-s3-bucket
  • Remove support for mfa_delete
  • Pin AWS provider < 4.0 and disable Renovate bot, closes #​64
  • General updates

why

  • Simplify maintenance and standardize on single S3 bucket module, in preparation for upgrade to Terraform AWS provider v4
  • With Terraform AWS provider v4, having mfa_delete enabled requires entering an MFA token for every Terraform operation, which is incompatible with automation. Users requiring mfa_delete should either not use Terraform or create their own fork.
  • Current module does not work with AWS v4, but Renovate would try to update it anyway
  • Stay current with boilerplate and management tools

notes

This is the first of 2 upgrade releases to get this module to support Terraform AWS Provider v4. We are breaking it into 2 releases so that users have the option of upgrading step-by-step rather than all at once. Upgrade instructions are here.

Cleanups and safety checks for upgrade @​Nuru (#​70)

what

  • Add warning to README and error when force_destroy is true
  • Maintain rule name for lifecycle rule
  • Disable Renovate bot

why

  • If force_destroy is true then an automated, unattended process could cause the S3 bucket to be deleted and all data in it irretrievably lost
  • Remove an unwanted and unneeded source of changes created by upgrading
  • This version should not be updated, it is pinned for compability

references

Closes Renovate PRs:

  • Closes #​67 (do not want)
  • Closes #​68 (incorporated via build-harness)
  • Closes #​69 (do not want)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

dylanbannon and others added 3 commits July 1, 2022 15:54
* git-xargs programmatic commit

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
@renovate renovate bot requested a review from a team as a code owner July 1, 2024 11:47
@renovate renovate bot added the auto-update This PR was automatically generated label Jul 1, 2024
@renovate renovate bot requested review from a team as code owners July 1, 2024 11:47
@renovate renovate bot requested review from kevcube and joe-niland and removed request for a team July 1, 2024 11:47
@renovate renovate bot changed the title chore(deps): update terraform cloudposse/s3-log-storage/aws to v0.28.3 (release/v0) chore(deps): update terraform cloudposse/s3-log-storage/aws to v0.28.3 (release/v0) - abandoned Jul 1, 2024
Copy link
Contributor Author

renovate bot commented Jul 1, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@mergify mergify bot added the readme Improvements or additions to the README label Jul 1, 2024
Copy link

mergify bot commented Jul 1, 2024

/terratest

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jul 1, 2024
Copy link

mergify bot commented Jul 1, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

Copy link
Contributor Author

renovate bot commented Jul 1, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated needs-cloudposse Needs Cloud Posse assistance readme Improvements or additions to the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants