Modify defaults for parent from empty strings to null. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to, it seems some changes to the `aws_route53_zone` data source in provider version 5.51.0, it seems using empty strings here causes an issue where the following error is received. ``` │ Error: Invalid combination of arguments │ │ with module.cloudfront.module.cloudfront_distribution.module.route53_alias.data.aws_route53_zone.default[0], │ on .terraform/modules/cloudfront.cloudfront_distribution.route53_alias/main.tf line 4, in data "aws_route53_zone" "default": │ 4: name = var.parent_zone_name │ │ "name": only one of `name,zone_id` can be specified, but `name,zone_id` │ were specified. ``` By using null in place of empty strings here, the validation seems to pass without issue. This can be validated by trying to use this module with 5.51.0, and finding that no matter which is provided both are interpreted as having been provided, triggering the error. [history of data source file](https://github.com/hashicorp/terraform-provider-aws/commits/0750cf2ce20f2b1cc6144176ce33593ba53b0220/internal/service/route53/zone_data_source.go)
yuekui
approved these changes
May 24, 2024
|
This should already be fixed by hashicorp/terraform-provider-aws#37686 |
|
Sounds good, @yuekui. Glad to hear it. I still think providing empty strings in lieu of not providing a value when the desired intent is no value, is an odd choice in languages with nulls; evil as they are. 😅 If this is merged, cool; if closed directly, that's sensible too. |
|
/terratest |
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to, it seems some changes to the
aws_route53_zonedata source in provider version 5.51.0, it seems using empty strings here causes an issue where the following error is received.By using null in place of empty strings here, the validation seems to pass without issue. This can be validated by trying to use this module with 5.51.0, and finding that no matter which is provided both are interpreted as having been provided, triggering the error.
history of data source
file