bug/193-enable-http-endpoint #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new variable to differentiate between standard serverless and serverless v2 configurations. Updated the logic for enabling HTTP endpoints to account for both serverless and serverless v2 setups.
…ed the enable_http_endpoint condition by removing redundant checks for improved clarity and maintainability.
|
/terratest |
|
@goruha Merging can be performed automatically with 1 approving review. |
goruha
approved these changes
Oct 1, 2024
|
These changes were released in v1.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
enable_http_endpointbased on whether the database instance was using serverless architecture. With the introduction of serverless v2 for certain database engines, there is a need to update the logic to accommodate these options.references
Closes #193