Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional unsafe params #431

Conversation

pnikonowicz
Copy link
Contributor

Summary

this allows for more unsafe params to be set.

this is to allow postgres to invoke and access
data persistent disks which are necessary in order to query the database to determine if a node is
primary during an HA configuration.

allows for privlaged and additional volumes
to be mounted

Backward Compatibility

Breaking Change? No

@pnikonowicz pnikonowicz requested a review from a team as a code owner July 31, 2024 14:24
Copy link

linux-foundation-easycla bot commented Jul 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pnikonowicz / name: Paul Nikonowicz (7528871)

@pnikonowicz pnikonowicz force-pushed the PG4TAS-405-remove-i-am-primary-flag branch from 27fa3d0 to b11b1d5 Compare July 31, 2024 14:29
this allows for more unsafe params to be set.

this is to allow postgres to invoke and access
data persistent disks which are necessary in order
to query the database to determine if a node is
primary during an HA configuration.

allows for privlaged and additional volumes
to be mounted
@pnikonowicz pnikonowicz force-pushed the PG4TAS-405-remove-i-am-primary-flag branch from b11b1d5 to 7528871 Compare July 31, 2024 14:32
@ameowlia
Copy link
Member

ameowlia commented Aug 6, 2024

Hi @pnikonowicz , Thanks for submitting this.

❓ Can you provide steps so I can deploy and test this behavior?
❓ Can you provide more information about why this is needed now, but was never needed before?

Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ read through code
✅ ran tests locally
✅ deployed code
✅ since bpm.yml template tests didn't exist before, I manually checked with a cf-d deployment that the configs didn't change.

Holding off on merging until the pipeline is green again.

@ameowlia ameowlia merged commit 256fe2d into cloudfoundry:develop Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants