Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP | Help needed] Update the Gorm version of the routing-api #339

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ZPascal
Copy link

@ZPascal ZPascal commented Aug 25, 2023

TODO:

  • Fix the routing-api component tests for the Gorm migration
  • Clarification about the missing PostgreSQL component test inside the routing-api part

What is this change about?

What type of change is this?

  • [Minor Feature/Improvement]

Backwards Compatibility

Expected behavior: The change should work as beforehand.

How should this be tested?

It should be deployed on a dev landscape. I've got no access to an dev landscape with an running deployment. We're not deploying the product on our landscapes.

Additional Context

Gorm migration to the new version to use pgx instead of lib/pq.

PR Checklist

@MarcPaquette
Copy link
Contributor

Hi @ZPascal,
I see where you are going with this and it looks promising. What sort of assistance are you looking for on this PR?

cc @tpbrisco

@ZPascal
Copy link
Author

ZPascal commented Apr 3, 2024

Hi @ZPascal, I see where you are going with this and it looks promising. What sort of assistance are you looking for on this PR?

cc @tpbrisco

Hi @MarcPaquette, I had a problem half a year ago with Ginkgo V2 and setting up a database index.
Screenshot 2023-10-23 at 14 28 11

I have modified the relevant line and I think it should have been adjusted correctly. It would be good if someone could give me some hints to debug the case further.
Screenshot 2023-10-23 at 14 40 07

On the other hand, I noticed that there was no component test for the PostgreSQL database in the past. Is there a reason for this or is it related to the use case/history?

I think I'll rebase the PRs and start revising them.

@ZPascal ZPascal force-pushed the migrate-the-used-gorm-version branch from f2f9166 to 2349bb7 Compare April 3, 2024 21:21
@tpbrisco
Copy link

tpbrisco commented Apr 3, 2024 via email

@tpbrisco
Copy link

tpbrisco commented Apr 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for Changes | Open for Contribution
Development

Successfully merging this pull request may close these issues.

3 participants