Cloud properties pw use

[Sascha222]

What is this change about?

We saw now in several situations that we are unable to solve issues fast, if we cannot access a failed or broken vm. We need access to the VM if the agent fails to startup so we can debug.

We want to have control over vcap password without interfering with other deployments.

Please provide contextual information.

https://www.starkandwayne.com/blog/how-to-lock-vcap-password-for-bosh-vms/index.html

What tests have you run against this PR?

• A Unittest in create_vm_step_spec.rb
• We uploaded the code in the local dev landscape and deployed a VM. The password defined in cloud-config was taken by the vm
• Ran all unittest in this repository

How should this change be described in bosh release notes?

In case of fixed vcap-password in cloud-config the corresponding password is set during deployment of VM’s.

Does this PR introduce a breaking change?

No as long no one configure a vcap password in cloud-config.

Tag your pair, your PM, and/or team!

@ansh-SAP @anshrupani @a-hassanin @Sascha-Stoj @cf-bosh

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Sascha-Stoj / name: Sascha Stojanovic (d186b0a)

[aramprice]

@Sascha-Stoj - could you say more about why this change is wanted, and what it what problem it is addressing?

[Sascha222]

@Sascha-Stoj - could you say more about why this change is wanted, and what it what problem it is addressing?

@aramprice - Hi commented the questionaire above. I hope it helps to clarify

[jpalermo]

Discussion at the 12/9/2024 FIWG meeting notes:

Overall goals for this are being able to configure a password/ssh credentials to a VM where the agent is failing to start, but without having to modify the deployment manifest.

Ideal place for this is probably something new in the runtime configs. This allows placement rules to be used to configure this, as well as all other env hash properties.

CloudProperties isn't a great fit for these things because CloudProperties are properties that bosh doesn't know anything about and assumes the CPI knows about them. But the env hash is something bosh does know about and is made available to the agent.