Add ostruct as an explicit dependency
#2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ostruct` gem historicially was shipped as part of Ruby. This is
going to change in Ruby 3.5.0, and currently not specifiying it causues
warning errors which are breaking tests.
This commit adds `ostruct` as a dependency in the bosh gems where it is
used.
Example error:
```
1) bin/bosh-template correctly renders a realistic nats config template
Failure/Error: expect(output[:stderr]).to eq('')
expected: ""
got: "/tmp/build/a94a8fe5/bosh-src/src/bosh-template/lib/bosh/template/renderer.rb:3: warning: ostruct was...tarting from Ruby 3.5.0.\nYou can add ostruct to your Gemfile or gemspec to silence this warning.\n"
```
jpalermo
approved these changes
Sep 6, 2024
xtreme-nitin-ravindran
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ostructgem historicially was shipped as part of Ruby. This is going to change in Ruby 3.5.0, and currently not specifiying it causues warning errors which are breaking tests.This commit adds
ostructas a dependency in the bosh gems where it is used.