Make Azure Cloud configurable for director blobstore #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalermo
requested review from
a team,
aramprice and
bgandon
and removed request for
a team
|
Maybe |
aramprice
approved these changes
Aug 31, 2024
jpalermo
requested changes
Sep 5, 2024
|
Highlighting the IaaS aspect is a good call. Additionally, it's worth noting that within the Azure CLI, this attribute is referred to as AZURE_CLOUD_NAME, whereas in the bosh-azure-cpi, it's termed as 'environment', where the IaaS context is more apparent. I'm comfortable with either naming convention, be it azure_cloud_name or azure_environment. @jpalermo feel free to choose whichever you prefer, and I'll adjust the PR. |
|
Lets keep it closer to the azure cli convention, hopefully that makes it make more sense for future contributors and users. |
|
@jpalermo sounds reasonable. I adapted the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
This change introduces a configuration option for the director blobstore that supports storage accounts on non-public Azure Clouds.
Please provide contextual information.
#2544
What tests have you run against this PR?
Deployed a director including these changes on AzureChinaCloud, replaced the bosh-azure-storage-cli with one that includes cloudfoundry/bosh-azure-storage-cli#16, and validated that issue #2544 is resolved.
How should this change be described in bosh release notes?
To enable configuration of the BOSH Director blobstore in different Azure Clouds, a new parameter
environmenthas been introduced. Users can specify the desired Azure Cloud environment (e.g., AzureUSGovernment, AzureChinaCloud) using the environment parameter in their BOSH Director configuration.Does this PR introduce a breaking change?
No.
Tag your pair, your PM, and/or team!
@jpalermo, @a-hassanin