Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bosh/integration build #2548

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

aramprice
Copy link
Member

  • uses .ruby-version to determine ruby version to install
  • installs latest bosh cli, meata4 cli, ruby-install executables
  • installs JDK from uaa-release

- uses `.ruby-version` to determine ruby version to install
- installs latest `bosh` cli, `meata4` cli, `ruby-install` executables
- installs JDK from `uaa-release`
- install all apt packages in a single `RUN` stanza
@aramprice aramprice force-pushed the integration-docker-image-uses-ruby-version branch from dc3a50d to 5afc650 Compare August 12, 2024 22:43
@aramprice
Copy link
Member Author

aramprice commented Aug 12, 2024

The build args generated (as of today) would be:

{
  "BOSH_CLI_URL": "https://github.com/cloudfoundry/bosh-cli/releases/download/v7.6.3/bosh-cli-7.6.3-linux-amd64",
  "META4_CLI_URL": "https://github.com/dpb587/metalink/releases/download/v0.5.0/meta4-0.5.0-linux-amd64",

  "RUBY_INSTALL_URL": "https://github.com/postmodern/ruby-install/releases/download/v0.9.3/ruby-install-0.9.3.tar.gz",
  "RUBY_VERSION": "3.2.5",
  "GEM_HOME": "/usr/local/bundle",

  "UAA_RELEASE_URL": "https://s3.amazonaws.com/bosh-compiled-release-tarballs/uaa-77.14.0-ubuntu-jammy-1.506.tgz",
  "JAVA_INSTALL_PREFIX": "/usr/lib/jvm",

  "POSTGRES_MAJOR_VERSION": "13"
}

These can be used to run docker build from ci/dockerfiles/integration/ as follows:

docker build \
--build-arg=BOSH_CLI_URL="https://github.com/cloudfoundry/bosh-cli/releases/download/v7.6.3/bosh-cli-7.6.3-linux-amd64" \
--build-arg=META4_CLI_URL="https://github.com/dpb587/metalink/releases/download/v0.5.0/meta4-0.5.0-linux-amd64" \
--build-arg=RUBY_INSTALL_URL="https://github.com/postmodern/ruby-install/releases/download/v0.9.3/ruby-install-0.9.3.tar.gz" \
--build-arg=RUBY_VERSION="3.2.5" \
--build-arg=GEM_HOME="/usr/local/bundle" \
--build-arg=UAA_RELEASE_URL="https://s3.amazonaws.com/bosh-compiled-release-tarballs/uaa-77.14.0-ubuntu-jammy-1.506.tgz" \
--build-arg=JAVA_INSTALL_PREFIX="/usr/lib/jvm" \
--build-arg=POSTGRES_MAJOR_VERSION="13" \
.

@jpalermo jpalermo requested review from a team, mvach and ramonskie and removed request for a team August 15, 2024 14:39
Copy link
Contributor

@fearoffish fearoffish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, both in principle and in implementation. Nice work.

@aramprice aramprice merged commit 2530e83 into main Aug 15, 2024
4 checks passed
@aramprice aramprice deleted the integration-docker-image-uses-ruby-version branch August 15, 2024 17:19
aramprice added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants