Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newer credhub versions require jdk 11 to run #2514

Merged
merged 1 commit into from
Apr 25, 2024
Merged

newer credhub versions require jdk 11 to run #2514

merged 1 commit into from
Apr 25, 2024

Conversation

nouseforaname
Copy link
Contributor

@nouseforaname nouseforaname commented Apr 24, 2024 •
edited
Loading

@jpalermo jpalermo requested review from a team, danielfor and klakin-pivotal and removed request for a team April 25, 2024 14:44
jpalermo
jpalermo approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jpalermo jpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's probably more correct 🤷‍♂️

@jpalermo jpalermo merged commit f061f70 into main Apr 25, 2024
4 checks passed
@jpalermo jpalermo deleted the update-jdk-in-image branch April 25, 2024 14:48
selzoc added a commit that referenced this pull request May 8, 2024
@jpalermo @aramprice @selzoc
🐞 integration tests use modern UAA
5fbb978 
Previous to this commit, the integration tests used a very very old
version of UAA (3.5.0) from an s3 bucket that needed Java 8.  Updates to
the integration Docker image that raised the JDK from 8->17 caused this
very old version to explode.

This commit represents a major refactoring of how UAA runs in the
integration specs.
* The UAA version now tracks the version in bosh-deployment
* There is only 1 UAA started, as opposed to 1 per spec process
* The UAA version is from uaa-release, and is templated accordingly

Java upgrade PRs:
* #2514
* #2515
* #2516

Co-authored-by: Aram Price <aram.price@broadcom.com>
Co-authored-by: Chris Selzo <chris.selzo@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpalermo jpalermo jpalermo approved these changes

@rkoster rkoster rkoster approved these changes

@danielfor danielfor Awaiting requested review from danielfor danielfor was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

@klakin-pivotal klakin-pivotal Awaiting requested review from klakin-pivotal klakin-pivotal was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nouseforaname @jpalermo @rkoster