Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local ssd support for n2 and n2d machine types #350

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Update local ssd support for n2 and n2d machine types #350

merged 4 commits into from
Jun 14, 2024

Conversation

jossy
Copy link
Contributor

@jossy jossy commented Jun 7, 2024

Newer machine types like n2 and n2d require a minimum number of local ssds to be requested depending on the number of vCPUs. In order to be able to create larger VMs with local ssds, this needs to be considered by the CPI.
We are using a patched version of the CPI at the moment to address this, but ideally we would like to get this merged.

More details here:
https://cloud.google.com/compute/docs/disks/local-ssd#lssd_disk_options

@rkoster rkoster requested review from a team, jpalermo and aramprice June 13, 2024 14:48
Copy link
Member

@jpalermo jpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated that without this patch it breaks when using larger n2 instance types.

With the patch I validated that it works with both larger n2 instance types specified via machine_type in the cloud properties.

Also validated that it works when specifying n2 as the machine_series and then specifying cpu and ram properties to create a custom n2 VM.

This doesn't seem to affect custom VMs created by only specifying cpu and ram.

Currently the additional local disks are not mounted by the agent. So if somebody wanted to make use of them, they'd have to do the mounting themself. We could update the bosh agent to mount them in the future, although without a good use case, it's hard to speculate how best to do that.

@jpalermo jpalermo merged commit 149ce9d into cloudfoundry:master Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants