Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more rules added and missing workflow added #11

Merged
merged 9 commits into from
Sep 14, 2023
Merged

fix: more rules added and missing workflow added #11

merged 9 commits into from
Sep 14, 2023

Conversation

d4kverma
Copy link
Member

what

  • More rules added and dfsec fixed.
  • aws rules added .

@clouddrove-ci clouddrove-ci self-assigned this Sep 11, 2023
themaniskshah
themaniskshah previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 13, 2023
View reviewed changes
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
_example/complete/example.tf Fixed Show fixed Hide fixed
nikitadugar
nikitadugar approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

13archit
13archit approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@13archit 13archit merged commit fb59767 into master Sep 14, 2023
48 checks passed
@delete-merged-branch delete-merged-branch bot deleted the identos-259-d branch September 14, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitadugar nikitadugar nikitadugar approved these changes

@13archit 13archit 13archit approved these changes

@themaniskshah themaniskshah themaniskshah left review comments

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@omsharma07 omsharma07 Awaiting requested review from omsharma07

Assignees

@clouddrove-ci clouddrove-ci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@d4kverma @nikitadugar @themaniskshah @13archit @clouddrove-ci @anmolnagpal @mamrajyadav