Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated arguments #50

Merged
merged 3 commits into from
May 31, 2023
Merged

removed deprecated arguments #50

merged 3 commits into from
May 31, 2023

Conversation

vibhutigoyal
Copy link
Contributor

what

  • removed deprecated arguments

why

  • need to remove

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:22-41
────────────────────────────────────────────────────────────────────────────────
   22  ┌ resource "aws_vpc" "default" {
   23count = var.vpc_enabled == true ? 1 : 0
   2425cidr_block                       = var.cidr_block
   26instance_tenancy                 = var.instance_tenancy
   27enable_dns_hostnames             = var.enable_dns_hostnames
   28enable_dns_support               = var.enable_dns_support
   29ipv4_ipam_pool_id                = var.ipv4_ipam_pool_id
   30ipv4_netmask_length              = var.ipv4_ipam_pool_id != "" ? var.ipv4_netmask_length : null
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             94.2µs
  parsing              86.049562ms
  adaptation           79.6µs
  checks               15.718493ms
  total                101.941855ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     49
  files read           3

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:22-41
────────────────────────────────────────────────────────────────────────────────
   22  ┌ resource "aws_vpc" "default" {
   23count = var.vpc_enabled ? 1 : 0
   2425cidr_block                       = var.cidr_block
   26instance_tenancy                 = var.instance_tenancy
   27enable_dns_hostnames             = var.enable_dns_hostnames
   28enable_dns_support               = var.enable_dns_support
   29ipv4_ipam_pool_id                = var.ipv4_ipam_pool_id
   30ipv4_netmask_length              = var.ipv4_ipam_pool_id != "" ? var.ipv4_netmask_length : null
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             84.901µs
  parsing              98.708486ms
  adaptation           101.601µs
  checks               9.155745ms
  total                108.050733ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     49
  files read           3

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:22-41
────────────────────────────────────────────────────────────────────────────────
   22  ┌ resource "aws_vpc" "default" {
   23count = var.vpc_enabled ? 1 : 0
   2425cidr_block                       = var.cidr_block
   26instance_tenancy                 = var.instance_tenancy
   27enable_dns_hostnames             = var.enable_dns_hostnames
   28enable_dns_support               = var.enable_dns_support
   29ipv4_ipam_pool_id                = var.ipv4_ipam_pool_id
   30ipv4_netmask_length              = var.ipv4_ipam_pool_id != "" ? var.ipv4_netmask_length : null
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             124.301µs
  parsing              45.48262ms
  adaptation           95.3µs
  checks               10.005049ms
  total                55.70727ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     48
  files read           3

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

Copy link
Contributor

@yadavprakash yadavprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadavprakash yadavprakash merged commit f49b818 into master May 31, 2023
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-441 branch May 31, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants