Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated tfsec.yaml file and bug: updated changelog.yml name and file #46

Merged
merged 2 commits into from
May 8, 2023

Conversation

vibhutigoyal
Copy link
Contributor

what

• updated .github/workflows changelog.yml name.

why

• need to rename this changelog.yml file

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:22-43
────────────────────────────────────────────────────────────────────────────────
   22  ┌ resource "aws_vpc" "default" {
   23count = var.vpc_enabled ? 1 : 0
   2425cidr_block                       = var.cidr_block
   26instance_tenancy                 = var.instance_tenancy
   27enable_dns_hostnames             = var.enable_dns_hostnames
   28enable_dns_support               = var.enable_dns_support
   29enable_classiclink               = var.enable_classiclink
   30enable_classiclink_dns_support   = var.enable_classiclink_dns_support
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             103.406µs
  parsing              75.219323ms
  adaptation           96.906µs
  checks               10.772319ms
  total                86.191954ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     51
  files read           3

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

feat: updated tfsec.yml file
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:22-43
────────────────────────────────────────────────────────────────────────────────
   22  ┌ resource "aws_vpc" "default" {
   23count = var.vpc_enabled ? 1 : 0
   2425cidr_block                       = var.cidr_block
   26instance_tenancy                 = var.instance_tenancy
   27enable_dns_hostnames             = var.enable_dns_hostnames
   28enable_dns_support               = var.enable_dns_support
   29enable_classiclink               = var.enable_classiclink
   30enable_classiclink_dns_support   = var.enable_classiclink_dns_support
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             107.101µs
  parsing              118.367478ms
  adaptation           84.902µs
  checks               9.59606ms
  total                128.155541ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     51
  files read           3

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@vibhutigoyal vibhutigoyal changed the title bug: updated changelog.yml name feat: updated tfsec.yaml file and bug: updated changelog.yml name and file May 8, 2023
Copy link
Contributor

@yadavprakash yadavprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadavprakash yadavprakash merged commit 2914698 into master May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the issue-362 branch May 8, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants