fix: Fixed tfcheks and defsec warnings

clouddrove · Sep 5, 2023 · e976b7b · e976b7b
1 parent f27d63f
commit e976b7b
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 12 deletions.
diff --git a/_example/multi_account/example.tf b/_example/multi_account/example.tf
@@ -29,6 +29,8 @@ module "vpc" {
 ##------------------------------------------------------------------------------
 ## Subnet module call.
 ##------------------------------------------------------------------------------
+#tfsec:ignore:aws-ec2-no-excessive-port-access # Ingnored because these are basic examples, it can be changed via varibales as per requirement. 
+#tfsec:ignore:aws-ec2-no-public-ingress-acl # Ingnored because these are basic examples, it can be changed via varibales as per requirement. 
 module "subnets" {
   source              = "clouddrove/subnet/aws"
   version             = "2.0.0"

diff --git a/_example/multi_account/outputs.tf b/_example/multi_account/outputs.tf
@@ -1,10 +1,10 @@
 output "tags" {
-  value       = module.transit-gateway.tags
+  value       = module.transit_gateway.tags
   description = "A mapping of tags to assign to the transit-gateway."
 }
 
 output "ram_resource_share_id" {
-  value       = module.transit-gateway.ram_resource_share_id
+  value       = module.transit_gateway.ram_resource_share_id
   description = "The Amazon Resource Name (ARN) of the resource share"
 }
 
@@ -14,6 +14,6 @@ output "ec2_transit_gateway_association_default_route_table_id" {
 }
 
 output "ec2_transit_gateway_vpc_attachment_ids" {
-  value       = module.transit-gateway.ec2_transit_gateway_vpc_attachment_ids
+  value       = module.transit_gateway.ec2_transit_gateway_vpc_attachment_ids
   description = "List of EC2 Transit Gateway VPC Attachment identifiers"
 }
diff --git a/_example/single_account/example.tf b/_example/single_account/example.tf
@@ -23,6 +23,8 @@ module "vpc" {
 ##------------------------------------------------------------------------------
 # Subnet module call.
 ##------------------------------------------------------------------------------
+#tfsec:ignore:aws-ec2-no-excessive-port-access # Ingnored because these are basic examples, it can be changed via varibales as per requirement. 
+#tfsec:ignore:aws-ec2-no-public-ingress-acl # Ingnored because these are basic examples, it can be changed via varibales as per requirement. 
 module "subnets" {
   source              = "clouddrove/subnet/aws"
   version             = "2.0.0"
@@ -51,6 +53,8 @@ module "vpc_other" {
 ##------------------------------------------------------------------------------
 # Other-subnet module call.
 ##------------------------------------------------------------------------------
+#tfsec:ignore:aws-ec2-no-excessive-port-access # Ingnored because these are basic examples, it can be changed via varibales as per requirement. 
+#tfsec:ignore:aws-ec2-no-public-ingress-acl # Ingnored because these are basic examples, it can be changed via varibales as per requirement. 
 module "subnets_other" {
   source              = "clouddrove/subnet/aws"
   version             = "2.0.0"

diff --git a/_example/single_account/outputs.tf b/_example/single_account/outputs.tf
@@ -1,44 +1,44 @@
 output "transit_gateway_id" {
-  value       = module.transit-gateway[*].transit_gateway_id
+  value       = module.transit_gateway[*].transit_gateway_id
   description = "The ID of the transit-gateway."
 }
 
 output "tags" {
-  value       = module.transit-gateway.tags
+  value       = module.transit_gateway.tags
   description = "A mapping of tags to assign to the transit-gateway."
 }
 
 output "ec2_transit_gateway_arn" {
-  value       = module.transit-gateway.ec2_transit_gateway_arn
+  value       = module.transit_gateway.ec2_transit_gateway_arn
   description = "EC2 Transit Gateway Amazon Resource Name (ARN)"
 }
 
 output "ec2_transit_gateway_route_table_id" {
-  value       = module.transit-gateway.ec2_transit_gateway_route_table_id
+  value       = module.transit_gateway.ec2_transit_gateway_route_table_id
   description = "EC2 Transit Gateway Route Table identifier"
 }
 
 output "ec2_transit_gateway_owner_id" {
-  value       = module.transit-gateway.ec2_transit_gateway_owner_id
+  value       = module.transit_gateway.ec2_transit_gateway_owner_id
   description = "Identifier of the AWS account that owns the EC2 Transit Gateway"
 }
 
 output "ec2_transit_gateway_association_default_route_table_id" {
-  value       = module.transit-gateway.ec2_transit_gateway_association_default_route_table_id
+  value       = module.transit_gateway.ec2_transit_gateway_association_default_route_table_id
   description = "Identifier of the default association route table"
 }
 
 output "ec2_transit_gateway_vpc_attachment_ids" {
-  value       = module.transit-gateway.ec2_transit_gateway_vpc_attachment_ids
+  value       = module.transit_gateway.ec2_transit_gateway_vpc_attachment_ids
   description = "List of EC2 Transit Gateway VPC Attachment identifiers"
 }
 
 output "ram_resource_share_id" {
-  value       = module.transit-gateway.ram_resource_share_id
+  value       = module.transit_gateway.ram_resource_share_id
   description = "The Amazon Resource Name (ARN) of the resource share"
 }
 
 output "resource_share_arn" {
-  value       = module.transit-gateway.resource_share_arn
+  value       = module.transit_gateway.resource_share_arn
   description = "The ARN  of the RAM."
 }